Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1910373002: Create platform/mojo and move MojoHelper.h there (Closed)

Created:
4 years, 8 months ago by kinuko
Modified:
4 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-reviews, chromium-reviews, darin (slow to review), haraken, kinuko+watch, Marijn Kruisselbrink, mlamouri+watch-blink_chromium.org, qsr+mojo_chromium.org, timvolodine, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create platform/mojo and move MojoHelper.h there so that: - we can avoid having base/bind.h in top-level DEPS in platform - other mojo-related files, e.g. mojo typemaps to convert things like URLs and origins between mojo types and blink types can be there - more structure in platform/ in general BUG=n/a R=haraken@chromium.org,esprehn@chromium.org,rouslan@chromium.org Committed: https://crrev.com/8cd882f07ae95e3aca0165feadb5a7c7ca3f6a42 Cr-Commit-Position: refs/heads/master@{#389047}

Patch Set 1 #

Patch Set 2 : rebase and add mojo/DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -71 lines) Patch
M third_party/WebKit/Source/modules/battery/BatteryDispatcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/DEPS View 2 chunks +0 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/platform/MojoHelper.h View 1 1 chunk +0 lines, -63 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/mojo/DEPS View 1 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/mojo/MojoHelper.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
haraken
LGTM
4 years, 8 months ago (2016-04-22 02:03:31 UTC) #1
kinuko
On 2016/04/22 02:03:31, haraken wrote: > LGTM thx!
4 years, 8 months ago (2016-04-22 02:05:00 UTC) #3
please use gerrit instead
lgtm
4 years, 8 months ago (2016-04-22 02:28:50 UTC) #4
esprehn
lgtm
4 years, 8 months ago (2016-04-22 03:17:16 UTC) #5
esprehn
It'd be really great to split up platform into directories with stricter DEPs.
4 years, 8 months ago (2016-04-22 03:17:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910373002/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910373002/2
4 years, 8 months ago (2016-04-22 03:27:47 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/209639)
4 years, 8 months ago (2016-04-22 05:21:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910373002/2 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910373002/2
4 years, 8 months ago (2016-04-22 05:39:53 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:2)
4 years, 8 months ago (2016-04-22 06:46:46 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:45:10 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8cd882f07ae95e3aca0165feadb5a7c7ca3f6a42
Cr-Commit-Position: refs/heads/master@{#389047}

Powered by Google App Engine
This is Rietveld 408576698