Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1910343006: Enable setting deferral state on ResourceDispatcher at request start (Closed)

Created:
4 years, 8 months ago by Nate Chapin
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Enable setting deferral state on ResourceDispatcher at request start In https://chromium.googlesource.com/chromium/src/+/f92a1f3b9, blink's ResourceLoader stopped handling load deferrals, instead leaving it to WebURLLoaderImpl. However, WebURLLoaderImpl can't quite do everything it needs to, as ResourceDispatcher also needs to note that the load is deferred, and it can't do that until a PendingRequest has been created. Give ResourceDispatcher a way to immediately mark a load a deferred on start. BUG=601706 Review URL: https://codereview.chromium.org/1881023004 Cr-Commit-Position: refs/heads/master@{#388910} (cherry picked from commit c5a3e99a81bee5f325b81be3d21f5daf1854b572) Committed: https://chromium.googlesource.com/chromium/src/+/cdb8e78779913eca8c5860c8cb8642752b2b9a83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
M content/child/resource_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_url_loader_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/child/web_url_loader_impl_unittest.cc View 3 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Nate Chapin
4 years, 8 months ago (2016-04-22 21:04:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cdb8e78779913eca8c5860c8cb8642752b2b9a83.

Powered by Google App Engine
This is Rietveld 408576698