Enable setting deferral state on ResourceDispatcher at request start

Enable setting deferral state on ResourceDispatcher at request start

In https://chromium.googlesource.com/chromium/src/+/f92a1f3b9,
blink's ResourceLoader stopped handling load deferrals,
instead leaving it to WebURLLoaderImpl. However,
WebURLLoaderImpl can't quite do everything it needs to, as
ResourceDispatcher also needs to note that the load is
deferred, and it can't do that until a PendingRequest has
been created. Give ResourceDispatcher a way to immediately
mark a load a deferred on start.

BUG=601706
Committed: https://crrev.com/c5a3e99a81bee5f325b81be3d21f5daf1854b572
Cr-Commit-Position: refs/heads/master@{#388910}

[Nate Chapin, 2016-04-13 17:58:46]

Description was changed from

==========
RequestInfo::defer_start

BUG=
==========

to

==========
Enable setting deferral state on ResourceDispatcher at request start

In https://chromium.googlesource.com/chromium/src/+/f92a1f3b9,
blink's ResourceLoader stopped handling load deferrals,
instead leaving it to WebURLLoaderImpl. However,
WebURLLoaderImpl can't quite do everything it needs to, as ResourceDispatcher
also needs to note that the load is
deferred, and it can't do that until a PendingRequest has
been created. Give ResourceDispatcher a way to immediately
mark a load a deferred on start.

BUG=601706
==========

[Nate Chapin, 2016-04-13 18:01:28]

Description was changed from

==========
Enable setting deferral state on ResourceDispatcher at request start

In https://chromium.googlesource.com/chromium/src/+/f92a1f3b9,
blink's ResourceLoader stopped handling load deferrals,
instead leaving it to WebURLLoaderImpl. However,
WebURLLoaderImpl can't quite do everything it needs to, as ResourceDispatcher
also needs to note that the load is
deferred, and it can't do that until a PendingRequest has
been created. Give ResourceDispatcher a way to immediately
mark a load a deferred on start.

BUG=601706
==========

to

==========
Enable setting deferral state on ResourceDispatcher at request start

In https://chromium.googlesource.com/chromium/src/+/f92a1f3b9,
blink's ResourceLoader stopped handling load deferrals,
instead leaving it to WebURLLoaderImpl. However,
WebURLLoaderImpl can't quite do everything it needs to, as
ResourceDispatcher also needs to note that the load is
deferred, and it can't do that until a PendingRequest has
been created. Give ResourceDispatcher a way to immediately
mark a load a deferred on start.

BUG=601706
==========

[Nate Chapin, 2016-04-13 19:35:37]

japhet@chromium.org changed reviewers:
+ dcheng@chromium.org

[Nate Chapin, 2016-04-13 19:35:37]

dcheng, is this something you're comfortable reviewing? See bug for context +
test case.

There appear to be two ways to fix this: Patch set 1, which is more complicated
but easy to test, and Patch set 2, which is clean and simple and would require
making a function or two on ResourceDispatcher protected instead of private in
order to unittest. Thoughts?

[dcheng, 2016-04-13 21:32:08]

I prefer PS2 and exposing things to tests (we could just friend the test too,
and then we wouldn't have to change anything, right?)

yhirano@ should probably review this though.

[Nate Chapin, 2016-04-15 20:11:56]

japhet@chromium.org changed reviewers:
+ yhirano@chromium.org

[Nate Chapin, 2016-04-15 20:11:56]

yhirano: PTAL

[yhirano, 2016-04-16 07:29:21]

On 2016/04/15 20:11:56, Nate Chapin wrote:
> yhirano: PTAL

Can you cc me in the crbug issue?

[dcheng, 2016-04-18 04:06:06]

Incidentally, I noticed the test case in the bug tripped a ton of asserts in
Blink: https://codereview.chromium.org/1898653002

Do you think it'd make sense to turn any of these into RELEASE_ASSERT?

[yhirano, 2016-04-18 05:50:37]

With PS2 we could make ResourceDispatcher::SetDefersLoading a virtual function
for testing.

[Nate Chapin, 2016-04-20 00:03:19]

The CQ bit was checked by japhet@chromium.org to run a CQ dry run

[Nate Chapin, 2016-04-20 00:03:44]

On 2016/04/18 05:50:37, yhirano wrote:
> With PS2 we could make ResourceDispatcher::SetDefersLoading a virtual function
> for testing.

Nice, I had missed that there were already some virtual-for-testing methods on
ResourceDispatcher. Test added.

[commit-bot: I haz the power, 2016-04-20 00:03:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881023004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881023004/40001

[commit-bot: I haz the power, 2016-04-20 00:57:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 00:57:42]

Dry run: This issue passed the CQ dry run.

[yhirano, 2016-04-20 02:30:18]

lgtm

[Nate Chapin, 2016-04-20 16:51:50]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2016-04-20 16:52:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881023004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881023004/40001

[commit-bot: I haz the power, 2016-04-20 16:59:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 16:59:19]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nate Chapin, 2016-04-20 19:59:51]

japhet@chromium.org changed reviewers:
+ jochen@chromium.org

[Nate Chapin, 2016-04-20 19:59:52]

jochen, would you mind content/OWNERS reviewing this?

[jochen (gone - plz use gerrit), 2016-04-21 14:47:26]

lgtm

[Nate Chapin, 2016-04-21 17:36:54]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2016-04-21 17:37:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881023004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881023004/40001

[commit-bot: I haz the power, 2016-04-21 20:36:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 20:36:41]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Nate Chapin, 2016-04-21 20:37:49]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2016-04-21 20:38:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881023004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881023004/40001

[commit-bot: I haz the power, 2016-04-21 21:44:16]

Description was changed from

==========
Enable setting deferral state on ResourceDispatcher at request start

In https://chromium.googlesource.com/chromium/src/+/f92a1f3b9,
blink's ResourceLoader stopped handling load deferrals,
instead leaving it to WebURLLoaderImpl. However,
WebURLLoaderImpl can't quite do everything it needs to, as
ResourceDispatcher also needs to note that the load is
deferred, and it can't do that until a PendingRequest has
been created. Give ResourceDispatcher a way to immediately
mark a load a deferred on start.

BUG=601706
==========

to

==========
Enable setting deferral state on ResourceDispatcher at request start

In https://chromium.googlesource.com/chromium/src/+/f92a1f3b9,
blink's ResourceLoader stopped handling load deferrals,
instead leaving it to WebURLLoaderImpl. However,
WebURLLoaderImpl can't quite do everything it needs to, as
ResourceDispatcher also needs to note that the load is
deferred, and it can't do that until a PendingRequest has
been created. Give ResourceDispatcher a way to immediately
mark a load a deferred on start.

BUG=601706
==========

[commit-bot: I haz the power, 2016-04-21 21:44:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:39:56]

Description was changed from

==========
Enable setting deferral state on ResourceDispatcher at request start

In https://chromium.googlesource.com/chromium/src/+/f92a1f3b9,
blink's ResourceLoader stopped handling load deferrals,
instead leaving it to WebURLLoaderImpl. However,
WebURLLoaderImpl can't quite do everything it needs to, as
ResourceDispatcher also needs to note that the load is
deferred, and it can't do that until a PendingRequest has
been created. Give ResourceDispatcher a way to immediately
mark a load a deferred on start.

BUG=601706
==========

to

==========
Enable setting deferral state on ResourceDispatcher at request start

In https://chromium.googlesource.com/chromium/src/+/f92a1f3b9,
blink's ResourceLoader stopped handling load deferrals,
instead leaving it to WebURLLoaderImpl. However,
WebURLLoaderImpl can't quite do everything it needs to, as
ResourceDispatcher also needs to note that the load is
deferred, and it can't do that until a PendingRequest has
been created. Give ResourceDispatcher a way to immediately
mark a load a deferred on start.

BUG=601706

Committed: https://crrev.com/c5a3e99a81bee5f325b81be3d21f5daf1854b572
Cr-Commit-Position: refs/heads/master@{#388910}
==========

[commit-bot: I haz the power, 2016-04-22 19:39:57]

Patchset 3 (id:??) landed as
https://crrev.com/c5a3e99a81bee5f325b81be3d21f5daf1854b572
Cr-Commit-Position: refs/heads/master@{#388910}