Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 191033002: Polish the appearance of the Controlled by Extension bubble. (Closed)

Created:
6 years, 9 months ago by Finnur
Modified:
6 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Polish the appearance of the Controlled by Extension bubble and change the link from "Manage extensions" (plural) to "Manage extension" (singular). By providing the ID to the chrome://extensions page it will automatically scroll to the right extension and highlight it. BUG=350869 R=dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255929

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -19 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/controlled_setting.css View 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/controlled_setting.js View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/uber/uber.js View 1 chunk +13 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/options/core_options_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Finnur
I'll forward you the before and after images.
6 years, 9 months ago (2014-03-07 16:40:46 UTC) #1
Dan Beam
is there a bug to track this? otherwise lgtm
6 years, 9 months ago (2014-03-07 20:22:52 UTC) #2
Finnur
On 2014/03/07 20:22:52, Dan Beam wrote: > is there a bug to track this? otherwise ...
6 years, 9 months ago (2014-03-10 10:53:03 UTC) #3
Finnur
The CQ bit was checked by finnur@chromium.org
6 years, 9 months ago (2014-03-10 12:01:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/191033002/1
6 years, 9 months ago (2014-03-10 12:02:06 UTC) #5
Finnur
Committed patchset #1 manually as r255929 (presubmit successful).
6 years, 9 months ago (2014-03-10 12:57:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/191033002/1
6 years, 9 months ago (2014-03-10 13:04:01 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 13:04:13 UTC) #8
Message was sent while issue was closed.
Failed to apply patch for chrome/app/generated_resources.grd:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/app/generated_resources.grd
  Hunk #1 FAILED at 10396.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/app/generated_resources.grd.rej

Patch:       chrome/app/generated_resources.grd
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd
b/chrome/app/generated_resources.grd
index
b31418d97efb084ca3f6953a5ffb70d12146a9a6..6176b67a82b9049a48b330737b3179dbd0b0bff8
100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -10396,8 +10396,8 @@ Would you like to start <ph
name="CONTROL_PANEL_APPLET_NAME">$1<ex>Add/Remove Pr
         <message name="IDS_OPTIONS_CONTROLLED_SETTING_EXTENSION_WITH_NAME"
desc="Text displayed in the controlled settings bubble when a setting's value is
enforced by an extension. The name of the extension would be displayed on the
following line, thus the ending with ':'.">
           This setting is controlled by:
         </message>
-        <message name="IDS_OPTIONS_CONTROLLED_SETTING_MANAGE_EXTENSIONS"
desc="Text displayed for a link to manage extensions from the controlled
settings bubble.">
-          Manage extensions
+        <message name="IDS_OPTIONS_CONTROLLED_SETTING_MANAGE_EXTENSION"
desc="Text displayed for a link to manage extension from the controlled settings
bubble.">
+          Manage extension
         </message>
         <message name="IDS_OPTIONS_CONTROLLED_SETTING_RECOMMENDED" desc="Text
displayed in the controlled settings bubble when a value is recommended for a
setting through policy and the user has not overridden this recommendation.">
           You are following the administrator's recommendation for this
setting.

Powered by Google App Engine
This is Rietveld 408576698