Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8640)

Unified Diff: chrome/browser/resources/options/controlled_setting.js

Issue 191033002: Polish the appearance of the Controlled by Extension bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/controlled_setting.js
diff --git a/chrome/browser/resources/options/controlled_setting.js b/chrome/browser/resources/options/controlled_setting.js
index 17048d43067cf092193f78c76d1cc635c1d8434e..d2436b76dba9c0db8fce77cfd434c1fbd632946b 100644
--- a/chrome/browser/resources/options/controlled_setting.js
+++ b/chrome/browser/resources/options/controlled_setting.js
@@ -142,6 +142,7 @@ cr.define('options', function() {
// Create the DOM tree.
var content = document.createElement('div');
+ content.classList.add('controlled-setting-bubble-header');
content.textContent = text;
if (this.controlledBy == 'hasRecommendation' && this.resetHandler_ &&
@@ -173,13 +174,14 @@ cr.define('options', function() {
var manageLink = extensionContainer.querySelector(
'.controlled-setting-bubble-extension-manage-link');
+ var extensionId = this.extensionId;
manageLink.onclick = function() {
uber.invokeMethodOnWindow(
- window.top, 'showPage', {pageId: 'extensions'});
+ window.top, 'showPage', {pageId: 'extensions',
+ path: '?id=' + extensionId});
};
var disableButton = extensionContainer.querySelector('button');
- var extensionId = this.extensionId;
disableButton.onclick = function() {
chrome.send('disableExtension', [extensionId]);
};
« no previous file with comments | « chrome/browser/resources/options/controlled_setting.css ('k') | chrome/browser/resources/options/options.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698