Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1910253003: PartitionAllocMemoryDumpProvider can directly inherit from MemoryDumpProvider (Closed)

Created:
4 years, 8 months ago by bashi
Modified:
4 years, 7 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, kinuko+watch, blink-reviews, Maria, DmitrySkiba, ssid
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PartitionAllocMemoryDumpProvider can directly inherit from MemoryDumpProvider WebMemoryDumpProviderAdapter was introduced when blink couldn't depend on base/trace_event. We no longer need it for PartionAllocMemoryDumper. BUG=605822 Committed: https://crrev.com/b873c0d4a990fc5a50d8de6fb71b65478492aefb Cr-Commit-Position: refs/heads/master@{#393193}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -57 lines) Patch
M base/trace_event/malloc_dump_provider.cc View 1 2 1 chunk +1 line, -7 lines 0 comments Download
M base/trace_event/process_memory_dump.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M base/trace_event/process_memory_dump.cc View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.h View 4 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp View 1 9 chunks +42 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/Platform.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
bashi
PTAL?
4 years, 8 months ago (2016-04-22 03:30:50 UTC) #2
Primiano Tucci (use gerrit)
This makes great sense to me, thanks. Only two things: 1) SHould we do the ...
4 years, 8 months ago (2016-04-22 13:05:57 UTC) #3
bashi
> Only two things: > 1) SHould we do the same also to BlinkGCMemoryDumpProvider for ...
4 years, 8 months ago (2016-04-24 23:33:13 UTC) #4
Primiano Tucci (use gerrit)
LGTM (note, I'm not an owner of Webkit/platform) +mariakhomenko, ssid, dskiba FYI
4 years, 8 months ago (2016-04-25 10:27:25 UTC) #5
bashi
Restarting working on this. haraken-san, PTAL?
4 years, 7 months ago (2016-05-12 01:36:03 UTC) #6
haraken
LGTM
4 years, 7 months ago (2016-05-12 02:15:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910253003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910253003/40001
4 years, 7 months ago (2016-05-12 02:16:11 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-12 05:41:15 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 05:43:07 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b873c0d4a990fc5a50d8de6fb71b65478492aefb
Cr-Commit-Position: refs/heads/master@{#393193}

Powered by Google App Engine
This is Rietveld 408576698