PartitionAllocMemoryDumpProvider can directly inherit from MemoryDumpProvider

PartitionAllocMemoryDumpProvider can directly inherit from MemoryDumpProvider

WebMemoryDumpProviderAdapter was introduced when blink couldn't depend
on base/trace_event. We no longer need it for PartionAllocMemoryDumper.

BUG=605822
Committed: https://crrev.com/b873c0d4a990fc5a50d8de6fb71b65478492aefb
Cr-Commit-Position: refs/heads/master@{#393193}

[bashi, 2016-04-22 03:30:50]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org, primiano@chromium.org

[bashi, 2016-04-22 03:30:50]

PTAL?

[Primiano Tucci (use gerrit), 2016-04-22 13:05:57]

This makes great sense to me, thanks.
Only two things:
1) SHould we do the same also to BlinkGCMemoryDumpProvider for consistency (is
the only other thing that uses the heap profiler left)

2) I think this partially conflicts (From a git sense) with what +mariakhomenko
is doing in https://codereview.chromium.org/1911643002/. Make sure you guys
syncup :)

https://codereview.chromium.org/1910253003/diff/1/base/trace_event/process_me...
File base/trace_event/process_memory_dump.h (right):

https://codereview.chromium.org/1910253003/diff/1/base/trace_event/process_me...
base/trace_event/process_memory_dump.h:122: void AddHeapDump(const std::string&
absolute_name,
at this point we can remove this, right?

https://codereview.chromium.org/1910253003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp
(right):

https://codereview.chromium.org/1910253003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp:119: if
(levelOfDetail == base::trace_event::MemoryDumpLevelOfDetail::DETAILED) {
maybe a "using base::trace_event::MemoryDumpLevelOfDetail" in the body of this
function could reduce the line length below?

[bashi, 2016-04-24 23:33:13]

> Only two things:
> 1) SHould we do the same also to BlinkGCMemoryDumpProvider for consistency (is
> the only other thing that uses the heap profiler left)

Yes. I'll do that in a follow-up CL.

> 2) I think this partially conflicts (From a git sense) with what
+mariakhomenko
> is doing in https://codereview.chromium.org/1911643002/. Make sure you guys
> syncup :)

Ack :)

https://codereview.chromium.org/1910253003/diff/1/base/trace_event/process_me...
File base/trace_event/process_memory_dump.h (right):

https://codereview.chromium.org/1910253003/diff/1/base/trace_event/process_me...
base/trace_event/process_memory_dump.h:122: void AddHeapDump(const std::string&
absolute_name,
On 2016/04/22 13:05:57, Primiano Tucci wrote:
> at this point we can remove this, right?

BlinkGCMemoryDumpProvider uses it indirectly. Added a TODO.

https://codereview.chromium.org/1910253003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp
(right):

https://codereview.chromium.org/1910253003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp:119: if
(levelOfDetail == base::trace_event::MemoryDumpLevelOfDetail::DETAILED) {
On 2016/04/22 13:05:57, Primiano Tucci wrote:
> maybe a "using base::trace_event::MemoryDumpLevelOfDetail" in the body of this
> function could reduce the line length below?

Done.

[Primiano Tucci (use gerrit), 2016-04-25 10:27:25]

LGTM (note, I'm not an owner of Webkit/platform)

+mariakhomenko, ssid, dskiba FYI

[bashi, 2016-05-12 01:36:03]

Restarting working on this. haraken-san, PTAL?

[haraken, 2016-05-12 02:15:00]

LGTM

[bashi, 2016-05-12 02:15:42]

The CQ bit was checked by bashi@chromium.org

[bashi, 2016-05-12 02:15:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/1910253003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-12 02:16:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1910253003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1910253003/40001

[commit-bot: I haz the power, 2016-05-12 05:41:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-12 05:43:06]

Description was changed from

==========
PartitionAllocMemoryDumpProvider can directly inherit from MemoryDumpProvider

WebMemoryDumpProviderAdapter was introduced when blink couldn't depend
on base/trace_event. We no longer need it for PartionAllocMemoryDumper.

BUG=605822
==========

to

==========
PartitionAllocMemoryDumpProvider can directly inherit from MemoryDumpProvider

WebMemoryDumpProviderAdapter was introduced when blink couldn't depend
on base/trace_event. We no longer need it for PartionAllocMemoryDumper.

BUG=605822

Committed: https://crrev.com/b873c0d4a990fc5a50d8de6fb71b65478492aefb
Cr-Commit-Position: refs/heads/master@{#393193}
==========

[commit-bot: I haz the power, 2016-05-12 05:43:07]

Patchset 3 (id:??) landed as
https://crrev.com/b873c0d4a990fc5a50d8de6fb71b65478492aefb
Cr-Commit-Position: refs/heads/master@{#393193}