Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Unified Diff: base/trace_event/malloc_dump_provider.cc

Issue 1910253003: PartitionAllocMemoryDumpProvider can directly inherit from MemoryDumpProvider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/trace_event/process_memory_dump.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/malloc_dump_provider.cc
diff --git a/base/trace_event/malloc_dump_provider.cc b/base/trace_event/malloc_dump_provider.cc
index eabe50ee216205740fb5be052be89febecc502fa..cf69859404e5a0b2694540d82e4f29461cdaea0f 100644
--- a/base/trace_event/malloc_dump_provider.cc
+++ b/base/trace_event/malloc_dump_provider.cc
@@ -192,13 +192,7 @@ bool MallocDumpProvider::OnMemoryDump(const MemoryDumpArgs& args,
allocation_register_->EstimateTraceMemoryOverhead(&overhead);
}
} // lock(allocation_register_lock_)
-
- if (!metrics_by_context.empty()) {
- std::unique_ptr<TracedValue> heap_dump = ExportHeapDump(
- metrics_by_context, *pmd->session_state());
- pmd->AddHeapDump("malloc", std::move(heap_dump));
- }
- overhead.DumpInto("tracing/heap_profiler_malloc", pmd);
+ pmd->DumpHeapUsage(metrics_by_context, overhead, "malloc");
}
tid_dumping_heap_ = kInvalidThreadId;
« no previous file with comments | « no previous file | base/trace_event/process_memory_dump.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698