Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1910123002: PPC64: [turbofan] Word32 loads should be unsigned. (Closed)

Created:
4 years, 8 months ago by MTBrandyberry
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC64: [turbofan] Word32 loads should be unsigned. TEST=cctest/test-run-load-store/* R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/e7d521fb5fb9229a65672b04797a29b7a1b6f315 Cr-Commit-Position: refs/heads/master@{#35733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -37 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 17 chunks +14 lines, -32 lines 0 comments Download
M src/compiler/ppc/instruction-codes-ppc.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-scheduler-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
MTBrandyberry
PTAL. Fixes the current set of PPC64-specific test failures.
4 years, 8 months ago (2016-04-21 18:42:23 UTC) #1
john.yan
lgtm
4 years, 8 months ago (2016-04-21 19:52:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910123002/1
4 years, 8 months ago (2016-04-21 19:58:40 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/554)
4 years, 8 months ago (2016-04-21 22:00:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910123002/1
4 years, 8 months ago (2016-04-21 22:30:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/559)
4 years, 8 months ago (2016-04-22 00:32:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910123002/1
4 years, 8 months ago (2016-04-22 13:36:44 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 14:04:57 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:45 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e7d521fb5fb9229a65672b04797a29b7a1b6f315
Cr-Commit-Position: refs/heads/master@{#35733}

Powered by Google App Engine
This is Rietveld 408576698