Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1910113002: Change DCHECK in SpdyWindowUpdateIR::set_delta(). (Closed)

Created:
4 years, 8 months ago by Bence
Modified:
4 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change DCHECK in SpdyWindowUpdateIR::set_delta(). This CL lands server change 116399439 by birenroy. BUG=488484 Committed: https://crrev.com/0f50d795b3a201afb0dfe3607aa11c671a27260a Cr-Commit-Position: refs/heads/master@{#388959}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/spdy/spdy_protocol.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 8 months ago (2016-04-21 18:56:37 UTC) #2
Ryan Hamilton
lgtm
4 years, 8 months ago (2016-04-21 21:09:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910113002/1
4 years, 8 months ago (2016-04-21 23:28:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 23:59:06 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:41:51 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0f50d795b3a201afb0dfe3607aa11c671a27260a
Cr-Commit-Position: refs/heads/master@{#388959}

Powered by Google App Engine
This is Rietveld 408576698