Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Side by Side Diff: net/spdy/spdy_protocol.h

Issue 1910113002: Change DCHECK in SpdyWindowUpdateIR::set_delta(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file contains some protocol structures for use with SPDY 3 and HTTP 2 5 // This file contains some protocol structures for use with SPDY 3 and HTTP 2
6 // The SPDY 3 spec can be found at: 6 // The SPDY 3 spec can be found at:
7 // http://dev.chromium.org/spdy/spdy-protocol/spdy-protocol-draft3 7 // http://dev.chromium.org/spdy/spdy-protocol/spdy-protocol-draft3
8 8
9 #ifndef NET_SPDY_SPDY_PROTOCOL_H_ 9 #ifndef NET_SPDY_SPDY_PROTOCOL_H_
10 #define NET_SPDY_SPDY_PROTOCOL_H_ 10 #define NET_SPDY_SPDY_PROTOCOL_H_
(...skipping 840 matching lines...) Expand 10 before | Expand all | Expand 10 after
851 }; 851 };
852 852
853 class NET_EXPORT_PRIVATE SpdyWindowUpdateIR : public SpdyFrameWithStreamIdIR { 853 class NET_EXPORT_PRIVATE SpdyWindowUpdateIR : public SpdyFrameWithStreamIdIR {
854 public: 854 public:
855 SpdyWindowUpdateIR(SpdyStreamId stream_id, int32_t delta) 855 SpdyWindowUpdateIR(SpdyStreamId stream_id, int32_t delta)
856 : SpdyFrameWithStreamIdIR(stream_id) { 856 : SpdyFrameWithStreamIdIR(stream_id) {
857 set_delta(delta); 857 set_delta(delta);
858 } 858 }
859 int32_t delta() const { return delta_; } 859 int32_t delta() const { return delta_; }
860 void set_delta(int32_t delta) { 860 void set_delta(int32_t delta) {
861 DCHECK_LT(0, delta); 861 DCHECK_LE(0, delta);
862 DCHECK_LE(delta, kSpdyMaximumWindowSize); 862 DCHECK_LE(delta, kSpdyMaximumWindowSize);
863 delta_ = delta; 863 delta_ = delta;
864 } 864 }
865 865
866 void Visit(SpdyFrameVisitor* visitor) const override; 866 void Visit(SpdyFrameVisitor* visitor) const override;
867 867
868 private: 868 private:
869 int32_t delta_; 869 int32_t delta_;
870 870
871 DISALLOW_COPY_AND_ASSIGN(SpdyWindowUpdateIR); 871 DISALLOW_COPY_AND_ASSIGN(SpdyWindowUpdateIR);
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
1068 SpdyFrameVisitor() {} 1068 SpdyFrameVisitor() {}
1069 virtual ~SpdyFrameVisitor() {} 1069 virtual ~SpdyFrameVisitor() {}
1070 1070
1071 private: 1071 private:
1072 DISALLOW_COPY_AND_ASSIGN(SpdyFrameVisitor); 1072 DISALLOW_COPY_AND_ASSIGN(SpdyFrameVisitor);
1073 }; 1073 };
1074 1074
1075 } // namespace net 1075 } // namespace net
1076 1076
1077 #endif // NET_SPDY_SPDY_PROTOCOL_H_ 1077 #endif // NET_SPDY_SPDY_PROTOCOL_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698