Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: chrome/browser/extensions/extension_message_service.cc

Issue 191010: Attempt at a fix for ExtensionBrowserTest.MessagingContentScript. (Closed)
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_browsertests_misc.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_message_service.cc
diff --git a/chrome/browser/extensions/extension_message_service.cc b/chrome/browser/extensions/extension_message_service.cc
index 70396c490da7a6f086b43c0412df380c6c35e9e5..95ff7f3b35a17c1f295f1b963d66e7f9bef71d26 100644
--- a/chrome/browser/extensions/extension_message_service.cc
+++ b/chrome/browser/extensions/extension_message_service.cc
@@ -153,11 +153,12 @@ void ExtensionMessageService::RemoveEventListener(const std::string& event_name,
// It is possible that this RenderProcessHost is being destroyed. If that is
// the case, we'll have already removed his listeners, so do nothing here.
RenderProcessHost* rph = RenderProcessHost::FromID(render_process_id);
- if (!rph)
+ if (!rph || rph->ListenersIterator().IsAtEnd())
return;
DCHECK_EQ(MessageLoop::current()->type(), MessageLoop::TYPE_UI);
- DCHECK_EQ(listeners_[event_name].count(render_process_id), 1u) << event_name;
+ DCHECK_EQ(listeners_[event_name].count(render_process_id), 1u)
+ << " PID=" << render_process_id << " event=" << event_name;
listeners_[event_name].erase(render_process_id);
if (extension_devtools_manager_.get()) {
« no previous file with comments | « chrome/browser/extensions/extension_browsertests_misc.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698