Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: chrome/browser/extensions/extension_message_service.cc

Issue 191010: Attempt at a fix for ExtensionBrowserTest.MessagingContentScript. (Closed)
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/extension_browsertests_misc.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_message_service.h" 5 #include "chrome/browser/extensions/extension_message_service.h"
6 6
7 #include "base/json_writer.h" 7 #include "base/json_writer.h"
8 #include "base/singleton.h" 8 #include "base/singleton.h"
9 #include "base/stl_util-inl.h" 9 #include "base/stl_util-inl.h"
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 extension_devtools_manager_->AddEventListener(event_name, 146 extension_devtools_manager_->AddEventListener(event_name,
147 render_process_id); 147 render_process_id);
148 } 148 }
149 } 149 }
150 150
151 void ExtensionMessageService::RemoveEventListener(const std::string& event_name, 151 void ExtensionMessageService::RemoveEventListener(const std::string& event_name,
152 int render_process_id) { 152 int render_process_id) {
153 // It is possible that this RenderProcessHost is being destroyed. If that is 153 // It is possible that this RenderProcessHost is being destroyed. If that is
154 // the case, we'll have already removed his listeners, so do nothing here. 154 // the case, we'll have already removed his listeners, so do nothing here.
155 RenderProcessHost* rph = RenderProcessHost::FromID(render_process_id); 155 RenderProcessHost* rph = RenderProcessHost::FromID(render_process_id);
156 if (!rph) 156 if (!rph || rph->ListenersIterator().IsAtEnd())
157 return; 157 return;
158 158
159 DCHECK_EQ(MessageLoop::current()->type(), MessageLoop::TYPE_UI); 159 DCHECK_EQ(MessageLoop::current()->type(), MessageLoop::TYPE_UI);
160 DCHECK_EQ(listeners_[event_name].count(render_process_id), 1u) << event_name; 160 DCHECK_EQ(listeners_[event_name].count(render_process_id), 1u)
161 << " PID=" << render_process_id << " event=" << event_name;
161 listeners_[event_name].erase(render_process_id); 162 listeners_[event_name].erase(render_process_id);
162 163
163 if (extension_devtools_manager_.get()) { 164 if (extension_devtools_manager_.get()) {
164 extension_devtools_manager_->RemoveEventListener(event_name, 165 extension_devtools_manager_->RemoveEventListener(event_name,
165 render_process_id); 166 render_process_id);
166 } 167 }
167 } 168 }
168 169
169 void ExtensionMessageService::AllocatePortIdPair(int* port1, int* port2) { 170 void ExtensionMessageService::AllocatePortIdPair(int* port1, int* port2) {
170 AutoLock lock(next_port_id_lock_); 171 AutoLock lock(next_port_id_lock_);
(...skipping 284 matching lines...) Expand 10 before | Expand all | Expand 10 after
455 for (MessageChannelMap::iterator it = channels_.begin(); 456 for (MessageChannelMap::iterator it = channels_.begin();
456 it != channels_.end(); ) { 457 it != channels_.end(); ) {
457 MessageChannelMap::iterator current = it++; 458 MessageChannelMap::iterator current = it++;
458 if (current->second->opener.sender == sender) { 459 if (current->second->opener.sender == sender) {
459 CloseChannelImpl(current, GET_CHANNEL_OPENER_ID(current->first)); 460 CloseChannelImpl(current, GET_CHANNEL_OPENER_ID(current->first));
460 } else if (current->second->receiver.sender == sender) { 461 } else if (current->second->receiver.sender == sender) {
461 CloseChannelImpl(current, GET_CHANNEL_RECEIVERS_ID(current->first)); 462 CloseChannelImpl(current, GET_CHANNEL_RECEIVERS_ID(current->first));
462 } 463 }
463 } 464 }
464 } 465 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_browsertests_misc.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698