Provide capability classes from Mus

Provide capability classes from Mus

- Allow mus to reject connections from sources that do not specify a class.

R=sky@chromium.org
BUG=

Committed: https://crrev.com/d566fafb3c810da8267e5a7f54420cd9c05c950e
Cr-Commit-Position: refs/heads/master@{#389310}

[sky, 2016-04-21 20:10:37]

https://codereview.chromium.org/1910043002/diff/40001/components/mus/manifest...
File components/mus/manifest.json (right):

https://codereview.chromium.org/1910043002/diff/40001/components/mus/manifest...
components/mus/manifest.json:11: "mus::mojom::WindowTreeFactory",
I tend to think WindowTreeFactory and WindowTreeHostFactory should be grouped in
their own capabilities too. We don't want random apps to be able to create top
level things.

https://codereview.chromium.org/1910043002/diff/40001/components/mus/manifest...
components/mus/manifest.json:18: "mus::mojom::WindowManagerFactoryService"
Is it worth having mus:window_manager contain everything in mus:core as well?
That way consumers don't need to list both.

[Ben Goodger (Google), 2016-04-21 21:14:00]

On 2016/04/21 20:10:37, sky wrote:
>
https://codereview.chromium.org/1910043002/diff/40001/components/mus/manifest...
> File components/mus/manifest.json (right):
> 
>
https://codereview.chromium.org/1910043002/diff/40001/components/mus/manifest...
> components/mus/manifest.json:11: "mus::mojom::WindowTreeFactory",
> I tend to think WindowTreeFactory and WindowTreeHostFactory should be grouped
in
> their own capabilities too. We don't want random apps to be able to create top
> level things.
> 
>
https://codereview.chromium.org/1910043002/diff/40001/components/mus/manifest...
> components/mus/manifest.json:18: "mus::mojom::WindowManagerFactoryService"
> Is it worth having mus:window_manager contain everything in mus:core as well?
> That way consumers don't need to list both.

Updated PTAL

[sky, 2016-04-21 21:24:53]

LGTM

[Ben Goodger (Google), 2016-04-21 21:30:07]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-04-21 21:30:08]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1910043002/#ps80001
(title: ".")

[commit-bot: I haz the power, 2016-04-21 21:30:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1910043002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1910043002/80001

[commit-bot: I haz the power, 2016-04-21 22:28:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 22:28:13]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-04-21 23:35:33]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2016-04-21 23:36:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1910043002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1910043002/80001

[commit-bot: I haz the power, 2016-04-22 01:14:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 01:14:34]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Ben Goodger (Google), 2016-04-22 17:54:46]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-04-22 17:54:47]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1910043002/#ps100001
(title: ".")

[commit-bot: I haz the power, 2016-04-22 17:55:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1910043002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1910043002/100001

[commit-bot: I haz the power, 2016-04-22 19:34:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 19:34:50]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-04-22 19:57:41]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-04-22 19:57:41]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1910043002/#ps120001
(title: ".")

[commit-bot: I haz the power, 2016-04-22 19:58:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1910043002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1910043002/120001

[commit-bot: I haz the power, 2016-04-22 20:34:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 20:34:43]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2016-04-22 21:19:30]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-04-22 21:19:30]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1910043002/#ps140001
(title: ".")

[commit-bot: I haz the power, 2016-04-22 21:20:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1910043002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1910043002/140001

[commit-bot: I haz the power, 2016-04-22 23:53:41]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-04-22 23:54:45]

Description was changed from

==========
Provide capability classes from Mus

- Allow mus to reject connections from sources that do not specify a class.

R=sky@chromium.org
BUG=
==========

to

==========
Provide capability classes from Mus

- Allow mus to reject connections from sources that do not specify a class.

R=sky@chromium.org
BUG=

Committed: https://crrev.com/d566fafb3c810da8267e5a7f54420cd9c05c950e
Cr-Commit-Position: refs/heads/master@{#389310}
==========

[commit-bot: I haz the power, 2016-04-22 23:54:46]

Patchset 8 (id:??) landed as
https://crrev.com/d566fafb3c810da8267e5a7f54420cd9c05c950e
Cr-Commit-Position: refs/heads/master@{#389310}

[Marc Treib, 2016-04-25 08:09:10]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1915853002/ by treib@chromium.org.

The reason for reverting is: Speculative revert: Seems to have broken
mash_unittests on Linux ChromiumOS GN:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%....

[Marc Treib, 2016-04-25 10:23:28]

On 2016/04/25 08:09:10, Marc Treib wrote:
> A revert of this CL (patchset #8 id:140001) has been created in
> https://codereview.chromium.org/1915853002/ by mailto:treib@chromium.org.
> 
> The reason for reverting is: Speculative revert: Seems to have broken
> mash_unittests on Linux ChromiumOS GN:
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%....

Reverting did indeed fix the tests.

[Ben Goodger (Google), 2016-04-25 18:19:17]

Description was changed from

==========
Provide capability classes from Mus

- Allow mus to reject connections from sources that do not specify a class.

R=sky@chromium.org
BUG=

Committed: https://crrev.com/d566fafb3c810da8267e5a7f54420cd9c05c950e
Cr-Commit-Position: refs/heads/master@{#389310}
==========

to

==========
Provide capability classes from Mus

- Allow mus to reject connections from sources that do not specify a class.

R=sky@chromium.org
BUG=

Committed: https://crrev.com/d566fafb3c810da8267e5a7f54420cd9c05c950e
Cr-Commit-Position: refs/heads/master@{#389310}
==========