Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: services/shell/public/cpp/lib/interface_registry.cc

Issue 1910043002: Provide capability classes from Mus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/shell/manifest.json ('k') | services/shell/shell.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/shell/public/cpp/lib/interface_registry.cc
diff --git a/services/shell/public/cpp/lib/interface_registry.cc b/services/shell/public/cpp/lib/interface_registry.cc
index 39e5d9010950ea331ec8d8dd73d65d0896004d61..27a132b6bc18142e19708f17d9f63410fb4d59ae 100644
--- a/services/shell/public/cpp/lib/interface_registry.cc
+++ b/services/shell/public/cpp/lib/interface_registry.cc
@@ -35,8 +35,14 @@ void InterfaceRegistry::GetInterface(const mojo::String& interface_name,
auto iter = name_to_binder_.find(interface_name);
InterfaceBinder* binder = iter != name_to_binder_.end() ? iter->second :
default_binder_;
- if (binder)
+ if (binder) {
binder->BindInterface(connection_, interface_name, std::move(handle));
+ } else {
+ LOG(ERROR) << "Connection CapabilityFilter prevented binding to interface: "
+ << interface_name << " connection_name:"
+ << connection_->GetConnectionName() << " remote_name:"
+ << connection_->GetRemoteIdentity().name();
+ }
}
bool InterfaceRegistry::SetInterfaceBinderForName(
@@ -48,10 +54,6 @@ bool InterfaceRegistry::SetInterfaceBinderForName(
name_to_binder_[interface_name] = binder;
return true;
}
- LOG(WARNING) << "Connection CapabilityFilter prevented binding to interface: "
- << interface_name << " connection_name:"
- << connection_->GetConnectionName() << " remote_name:"
- << connection_->GetRemoteIdentity().name();
return false;
}
« no previous file with comments | « services/shell/manifest.json ('k') | services/shell/shell.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698