Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Issue 191003007: Use isSVG*Element() helpers more in SVG code (Part 3) (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, fs, blink-layers+watch_chromium.org, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, Stephen Chennney, rwlbuis
Visibility:
Public.

Description

Use isSVG*Element() helpers more in SVG code (Part 3) Use isSVG*Element() helpers more in SVG rendering code. Also use the Traversal<SVG*Element> API where suitable. This makes the code clearer and simpler. R=pdr BUG=346095 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -94 lines) Patch
M Source/core/rendering/RenderLayerFilterInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/ReferenceFilterBuilder.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGEllipse.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGGradientStop.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInline.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMasker.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGTSpan.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGTextPath.cpp View 2 chunks +6 lines, -5 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGTransformableContainer.cpp View 3 chunks +8 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGViewportContainer.cpp View 6 chunks +11 lines, -9 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 1 chunk +28 lines, -27 lines 0 comments Download
M Source/core/rendering/svg/SVGResources.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/rendering/svg/SVGRootInlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextRunRenderingContext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Inactive
6 years, 9 months ago (2014-03-09 03:14:27 UTC) #1
Inactive
6 years, 9 months ago (2014-03-10 00:35:20 UTC) #2
pdr.
On 2014/03/10 00:35:20, Chris Dumez wrote: LGTM, rs=me. I'm about to hop on a plane ...
6 years, 9 months ago (2014-03-10 00:50:19 UTC) #3
Inactive
On 2014/03/10 00:50:19, pdr wrote: > On 2014/03/10 00:35:20, Chris Dumez wrote: > > LGTM, ...
6 years, 9 months ago (2014-03-10 00:57:29 UTC) #4
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 9 months ago (2014-03-10 00:57:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/191003007/1
6 years, 9 months ago (2014-03-10 00:57:56 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 01:13:50 UTC) #7
Message was sent while issue was closed.
Change committed as 168808

Powered by Google App Engine
This is Rietveld 408576698