Source/core/rendering/svg/RenderSVGGradientStop.cpp - Issue 191003007: Use isSVG*Element() helpers more in SVG code (Part 3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGGradientStop.cpp

Issue 191003007: Use isSVG*Element() helpers more in SVG code (Part 3) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/RenderSVGGradientStop.cpp

diff --git a/Source/core/rendering/svg/RenderSVGGradientStop.cpp b/Source/core/rendering/svg/RenderSVGGradientStop.cpp

index ca5f315a7bc46f660b03b9a0e36d6a2a6cdd1258..2d66b5ddab4e014a12e87e8c337875dd67c1e98e 100644

--- a/Source/core/rendering/svg/RenderSVGGradientStop.cpp

+++ b/Source/core/rendering/svg/RenderSVGGradientStop.cpp

@@ -67,9 +67,8 @@ void RenderSVGGradientStop::layout()

SVGGradientElement* RenderSVGGradientStop::gradientElement() const

{

ContainerNode* parentNode = node()->parentNode();

- if (parentNode->hasTagName(linearGradientTag) || parentNode->hasTagName(radialGradientTag))

- return toSVGGradientElement(parentNode);

- return 0;

+ ASSERT(parentNode);

+ return isSVGGradientElement(*parentNode) ? toSVGGradientElement(parentNode) : 0;

}