Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1910023002: Remove partial blockfile v3 disk_cache implementation. (Closed)

Created:
4 years, 8 months ago by gavinp
Modified:
4 years, 8 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove partial blockfile v3 disk_cache implementation. This isn't being worked on; so it's been sad seeing this code updated with various refactorings and such. Also, it's a bit scary how we were just relying on linker dead code elimination to protect our binary size. R=davidben@chromium.org BUG=241277 Committed: https://crrev.com/1b45006a139d227d5570e2bd77943ebfc0bf96b3 Cr-Commit-Position: refs/heads/master@{#388976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8625 lines) Patch
M net/BUILD.gn View 2 chunks +0 lines, -7 lines 0 comments Download
M net/disk_cache/blockfile/addr.h View 2 chunks +2 lines, -5 lines 0 comments Download
M net/disk_cache/blockfile/addr.cc View 3 chunks +4 lines, -34 lines 0 comments Download
M net/disk_cache/blockfile/addr_unittest.cc View 1 chunk +10 lines, -12 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
D net/disk_cache/blockfile/backend_impl_v3.h View 1 chunk +0 lines, -287 lines 0 comments Download
D net/disk_cache/blockfile/backend_impl_v3.cc View 1 chunk +0 lines, -1545 lines 0 comments Download
D net/disk_cache/blockfile/backend_worker_v3.h View 1 chunk +0 lines, -57 lines 0 comments Download
D net/disk_cache/blockfile/backend_worker_v3.cc View 1 chunk +0 lines, -471 lines 0 comments Download
D net/disk_cache/blockfile/block_bitmaps_v3.h View 1 chunk +0 lines, -66 lines 0 comments Download
D net/disk_cache/blockfile/block_bitmaps_v3.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D net/disk_cache/blockfile/block_bitmaps_v3_unittest.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M net/disk_cache/blockfile/block_files.h View 1 chunk +0 lines, -1 line 0 comments Download
D net/disk_cache/blockfile/disk_format_v3.h View 1 chunk +0 lines, -248 lines 0 comments Download
M net/disk_cache/blockfile/entry_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
D net/disk_cache/blockfile/entry_impl_v3.h View 1 chunk +0 lines, -223 lines 0 comments Download
D net/disk_cache/blockfile/entry_impl_v3.cc View 1 chunk +0 lines, -1483 lines 0 comments Download
D net/disk_cache/blockfile/eviction_v3.h View 1 chunk +0 lines, -78 lines 0 comments Download
D net/disk_cache/blockfile/eviction_v3.cc View 1 chunk +0 lines, -516 lines 0 comments Download
D net/disk_cache/blockfile/histogram_macros_v3.h View 1 chunk +0 lines, -111 lines 0 comments Download
D net/disk_cache/blockfile/index_table_v3.h View 1 chunk +0 lines, -286 lines 0 comments Download
D net/disk_cache/blockfile/index_table_v3.cc View 1 chunk +0 lines, -1152 lines 0 comments Download
D net/disk_cache/blockfile/index_table_v3_unittest.cc View 1 chunk +0 lines, -711 lines 0 comments Download
M net/disk_cache/blockfile/rankings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D net/disk_cache/blockfile/sparse_control_v3.h View 1 chunk +0 lines, -180 lines 0 comments Download
D net/disk_cache/blockfile/sparse_control_v3.cc View 1 chunk +0 lines, -873 lines 0 comments Download
M net/net.gyp View 2 chunks +0 lines, -7 lines 0 comments Download
M net/net.gypi View 3 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
gavinp
mmenke: WDYT?
4 years, 8 months ago (2016-04-21 18:16:23 UTC) #1
mmenke
On 2016/04/21 18:16:23, gavinp wrote: > mmenke: WDYT? Could you find someone else to review ...
4 years, 8 months ago (2016-04-21 18:31:25 UTC) #2
gavinp
mmenke: your wish is my command. Now FYI. davidben: PTAL.
4 years, 8 months ago (2016-04-21 18:33:11 UTC) #5
davidben
Yay deleting code. lgtm. Should we close https://crbug.com/241277?
4 years, 8 months ago (2016-04-21 18:38:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910023002/1
4 years, 8 months ago (2016-04-21 23:26:08 UTC) #9
gavinp
On 2016/04/21 18:38:08, davidben wrote: > Yay deleting code. lgtm. > > Should we close ...
4 years, 8 months ago (2016-04-21 23:27:16 UTC) #10
gavinp
On 2016/04/21 23:27:16, gavinp wrote: > On 2016/04/21 18:38:08, davidben wrote: > > Yay deleting ...
4 years, 8 months ago (2016-04-21 23:50:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910023002/1
4 years, 8 months ago (2016-04-21 23:51:29 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 00:33:36 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:42:26 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b45006a139d227d5570e2bd77943ebfc0bf96b3
Cr-Commit-Position: refs/heads/master@{#388976}

Powered by Google App Engine
This is Rietveld 408576698