Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1909813002: Enable per thread heap for database thread (Closed)

Created:
4 years, 8 months ago by keishi
Modified:
4 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable per thread heap for database thread BUG=591606 Committed: https://crrev.com/993e3a74102e0843bebb2f52de1a904f151843d4 Committed: https://crrev.com/20a19e64ad3ca5728e557762b7040731b93400c4 Cr-Original-Commit-Position: refs/heads/master@{#397383} Cr-Commit-Position: refs/heads/master@{#398558}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 4

Patch Set 7 : #

Patch Set 8 : #

Total comments: 5

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Total comments: 3

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Total comments: 1

Patch Set 15 : #

Patch Set 16 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -50 lines) Patch
M third_party/WebKit/Source/modules/webdatabase/Database.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/Database.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseAuthorizer.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseContext.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseThread.h View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp View 1 2 3 4 5 6 7 8 9 5 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLResultSet.cpp View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLStatement.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLStatementBackend.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransaction.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 7 chunks +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.h View 1 2 3 4 5 6 7 2 chunks +5 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp View 1 2 3 4 5 6 7 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteDatabase.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 46 (16 generated)
keishi
Relies on https://codereview.chromium.org/1974693002/
4 years, 7 months ago (2016-05-18 12:55:37 UTC) #2
haraken
https://codereview.chromium.org/1909813002/diff/100001/third_party/WebKit/Source/modules/webdatabase/Database.cpp File third_party/WebKit/Source/modules/webdatabase/Database.cpp (right): https://codereview.chromium.org/1909813002/diff/100001/third_party/WebKit/Source/modules/webdatabase/Database.cpp#newcode218 third_party/WebKit/Source/modules/webdatabase/Database.cpp:218: ASSERT(isMainThread()); Use DCHECK. https://codereview.chromium.org/1909813002/diff/100001/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.h File third_party/WebKit/Source/modules/webdatabase/DatabaseThread.h (right): https://codereview.chromium.org/1909813002/diff/100001/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.h#newcode80 third_party/WebKit/Source/modules/webdatabase/DatabaseThread.h:80: ...
4 years, 7 months ago (2016-05-18 13:05:16 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909813002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909813002/120001
4 years, 7 months ago (2016-05-20 05:30:30 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/231386)
4 years, 7 months ago (2016-05-20 07:23:34 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909813002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909813002/120001
4 years, 7 months ago (2016-05-20 09:37:23 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/232840)
4 years, 7 months ago (2016-05-20 10:50:31 UTC) #11
keishi
PTAL https://codereview.chromium.org/1909813002/diff/100001/third_party/WebKit/Source/modules/webdatabase/Database.cpp File third_party/WebKit/Source/modules/webdatabase/Database.cpp (right): https://codereview.chromium.org/1909813002/diff/100001/third_party/WebKit/Source/modules/webdatabase/Database.cpp#newcode218 third_party/WebKit/Source/modules/webdatabase/Database.cpp:218: ASSERT(isMainThread()); On 2016/05/18 13:05:16, haraken wrote: > > ...
4 years, 7 months ago (2016-05-24 11:52:21 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909813002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909813002/140001
4 years, 7 months ago (2016-05-24 11:52:56 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/227053)
4 years, 7 months ago (2016-05-24 14:20:38 UTC) #16
haraken
Can we split the CL into two pieces: 1) changes to platform/heap/ and 2) enabling ...
4 years, 7 months ago (2016-05-24 16:15:28 UTC) #17
keishi
Split into three parts: 1. Add checks for per thread heap https://codereview.chromium.org/2012763002/ 2. Allow CrossThreadPersistent ...
4 years, 7 months ago (2016-05-25 13:07:45 UTC) #18
haraken
On 2016/05/25 13:07:45, keishi wrote: > Split into three parts: > > 1. Add checks ...
4 years, 7 months ago (2016-05-25 15:46:35 UTC) #19
keishi
I created a CL for the CrossThreadPersistent::get check here https://codereview.chromium.org/2019963002/ I think the absolutely necessary ...
4 years, 6 months ago (2016-06-02 02:01:02 UTC) #20
haraken
I still want to remove CrossThreadPersistent::get() (for the reason I mentioned in https://codereview.chromium.org/2019963002/) but I ...
4 years, 6 months ago (2016-06-02 02:23:31 UTC) #21
keishi
https://codereview.chromium.org/1909813002/diff/200001/third_party/WebKit/Source/platform/heap/Heap.h File third_party/WebKit/Source/platform/heap/Heap.h (right): https://codereview.chromium.org/1909813002/diff/200001/third_party/WebKit/Source/platform/heap/Heap.h#newcode208 third_party/WebKit/Source/platform/heap/Heap.h:208: if (&ThreadState::current()->heap() == &pageFromObject(object)->arena()->getThreadState()->heap()) On 2016/06/02 02:23:31, haraken wrote: ...
4 years, 6 months ago (2016-06-02 02:58:53 UTC) #22
haraken
LGTM
4 years, 6 months ago (2016-06-02 04:17:56 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909813002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909813002/220001
4 years, 6 months ago (2016-06-02 04:44:53 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/179607)
4 years, 6 months ago (2016-06-02 05:13:04 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909813002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909813002/220001
4 years, 6 months ago (2016-06-02 12:27:12 UTC) #29
commit-bot: I haz the power
Committed patchset #12 (id:220001)
4 years, 6 months ago (2016-06-02 13:35:03 UTC) #30
commit-bot: I haz the power
Patchset 12 (id:??) landed as https://crrev.com/993e3a74102e0843bebb2f52de1a904f151843d4 Cr-Commit-Position: refs/heads/master@{#397383}
4 years, 6 months ago (2016-06-02 13:36:45 UTC) #32
haraken
A revert of this CL (patchset #12 id:220001) has been created in https://codereview.chromium.org/2037233002/ by haraken@chromium.org. ...
4 years, 6 months ago (2016-06-03 23:43:43 UTC) #33
keishi
https://codereview.chromium.org/1909813002/diff/260001/third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.h File third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.h (right): https://codereview.chromium.org/1909813002/diff/260001/third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.h#newcode108 third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.h:108: CrossThreadPersistent<SQLTransaction> m_frontend; This change is for crbug.com/616984. I had ...
4 years, 6 months ago (2016-06-08 04:56:17 UTC) #35
keishi
On 2016/06/08 04:56:17, keishi wrote: > https://codereview.chromium.org/1909813002/diff/260001/third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.h > File third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.h > (right): > > https://codereview.chromium.org/1909813002/diff/260001/third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.h#newcode108 ...
4 years, 6 months ago (2016-06-08 06:17:23 UTC) #36
haraken
On 2016/06/08 06:17:23, keishi wrote: > On 2016/06/08 04:56:17, keishi wrote: > > > https://codereview.chromium.org/1909813002/diff/260001/third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.h ...
4 years, 6 months ago (2016-06-08 06:23:40 UTC) #37
sof
On 2016/06/08 06:23:40, haraken wrote: > On 2016/06/08 06:17:23, keishi wrote: > > On 2016/06/08 ...
4 years, 6 months ago (2016-06-08 06:35:54 UTC) #38
haraken
On 2016/06/08 06:35:54, sof wrote: > On 2016/06/08 06:23:40, haraken wrote: > > On 2016/06/08 ...
4 years, 6 months ago (2016-06-08 06:55:23 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909813002/300001
4 years, 6 months ago (2016-06-08 11:41:57 UTC) #42
commit-bot: I haz the power
Committed patchset #16 (id:300001)
4 years, 6 months ago (2016-06-08 15:15:28 UTC) #44
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 15:16:22 UTC) #46
Message was sent while issue was closed.
Patchset 16 (id:??) landed as
https://crrev.com/20a19e64ad3ca5728e557762b7040731b93400c4
Cr-Commit-Position: refs/heads/master@{#398558}

Powered by Google App Engine
This is Rietveld 408576698