Source/core/dom/Document.cpp - Issue 19098002: Introduce isHTMLHtmlElement and toHTMLHtmlElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.cpp

Issue 19098002: Introduce isHTMLHtmlElement and toHTMLHtmlElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index c9369c2a2348a719612179199e3bcb51bb314a85..95f472d66f5410d5b3092bf470ae642040180b90 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -104,6 +104,7 @@

#include "core/html/HTMLDocument.h"

#include "core/html/HTMLFrameOwnerElement.h"

#include "core/html/HTMLHeadElement.h"

+#include "core/html/HTMLHtmlElement.h"

#include "core/html/HTMLIFrameElement.h"

#include "core/html/HTMLImport.h"

#include "core/html/HTMLLinkElement.h"

@@ -684,7 +685,7 @@ DOMImplementation* Document::implementation()

bool Document::hasManifest() const

{

- return documentElement() && documentElement()->hasTagName(htmlTag) && documentElement()->hasAttribute(manifestAttr);

+ return documentElement() && isHTMLHtmlElement(documentElement()) && documentElement()->hasAttribute(manifestAttr);

}

void Document::childrenChanged(bool changedByParser, Node* beforeChange, Node* afterChange, int childCountDelta)

@@ -2312,7 +2313,7 @@ bool Document::shouldScheduleLayout()

// (b) Only schedule layout once we have a body element.

return (haveStylesheetsLoaded() && body())

- || (documentElement() && !documentElement()->hasTagName(htmlTag));

+ || (documentElement() && !isHTMLHtmlElement(documentElement()));

}

bool Document::isLayoutTimerActive()

« no previous file with comments | « Source/core/css/resolver/StyleResolver.cpp ('k') | Source/core/dom/Position.cpp » ('j') | no next file with comments »