Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 19096012: gm: since we don't record output of gpudebug test, don't record checksums either (Closed)

Created:
7 years, 5 months ago by epoger
Modified:
7 years, 5 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

gm: since we don't record output of gpudebug test, don't record checksums either BUG=https://code.google.com/p/skia/issues/detail?id=1410 R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=10046

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M gm/gmmain.cpp View 2 chunks +10 lines, -1 line 1 comment Download

Messages

Total messages: 4 (0 generated)
epoger
Ready for review... https://codereview.chromium.org/19096012/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/19096012/diff/1/gm/gmmain.cpp#newcode929 gm/gmmain.cpp:929: } else if (!(gRec.fFlags & kWrite_ConfigFlag)) ...
7 years, 5 months ago (2013-07-12 15:44:08 UTC) #1
robertphillips
lgtm. Whatever happened to the NULL GPU config?
7 years, 5 months ago (2013-07-12 15:49:00 UTC) #2
epoger
On 2013/07/12 15:49:00, robertphillips wrote: > lgtm. > Whatever happened to the NULL GPU config? ...
7 years, 5 months ago (2013-07-12 15:52:45 UTC) #3
epoger
7 years, 5 months ago (2013-07-12 15:53:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r10046 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698