gm: since we don't record output of gpudebug test, don't record checksums either

gm/gmmain.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*
  * Code for the "gm" (Golden Master) rendering comparison tool.
  *
@@ skipping 908 matching lines @@
         nameWithExtension.append(kPNG_FileExtension);
 
         ErrorCombination errors;
 
         if (NULL == actualBitmapAndDigest) {
             // Note that we intentionally skipped validating the results for
             // this test, because we don't know how to generate an SkBitmap
             // version of the output.
             RecordTestResults(ErrorCombination(kIntentionallySkipped_ErrorType),
                               shortNamePlusConfig, "");
+        } else if (!(gRec.fFlags & kWrite_ConfigFlag)) {

[epoger, 2013/07/12 15:44:08]

Tested as follows:

$ out/Debug/gm --config gpudebug --writePath tmp --verbose --match xfermodes2
--writeJsonSummaryPath tmp/out.json
Non-default runtime configuration options:
GM: These configs will be run: gpudebug
GM: writing to tmp
GM: drawing... xfermodes2 [455 475]
GM: Ran 1 GMs
GM: ... over  1 configs ["gpudebug"]
GM: ...  and  7 modes   ["pipe", "pipe cross-process", "pipe cross-process,
shared address", "replay", "rtree", "serialize", "tilegrid"]
GM: ... so there should be a total of 8 tests.
GM: Ran 8 tests: NoGpuContext=0 IntentionallySkipped=1 RenderModeMismatch=0
ExpectationsMismatch=0 MissingExpectations=0 WritingReferenceImage=0
GM: [*] 0 NoGpuContext:
GM: [ ] 1 IntentionallySkipped: xfermodes2_gpudebug
GM: [*] 0 RenderModeMismatch:
GM: [*] 0 ExpectationsMismatch:
GM: [ ] 0 MissingExpectations:
GM: [*] 0 WritingReferenceImage:
GM: (results marked with [*] will cause nonzero return value)
--- Program Cache ---
Total requests: 350
Cache misses: 20
Cache miss %: 5.714286
Hash miss %: 3.939394
---------------------

$ ls tmp
out.json

$ cat tmp/out.json
 {
   "actual-results" : {
      "failed" : null,
      "failure-ignored" : null,
      "no-comparison" : null,
      "succeeded" : null
   },
   "expected-results" : null
}

+            // We don't record the results for this test or compare them
+            // against any expectations, because the output image isn't
+            // meaningful.
+            // See https://code.google.com/p/skia/issues/detail?id=1410 ('some
+            // GM result images not available for download from Google Storage')
+            RecordTestResults(ErrorCombination(kIntentionallySkipped_ErrorType),
+                              shortNamePlusConfig, "");
         } else {
             ExpectationsSource *expectationsSource = this->fExpectationsSource.get();
             if (expectationsSource && (gRec.fFlags & kRead_ConfigFlag)) {
                 /*
                  * Get the expected results for this test, as one or more allowed
                  * hash digests. The current implementation of expectationsSource
                  * get this by computing the hash digest of a single PNG file on disk.
                  *
                  * TODO(epoger): This relies on the fact that
                  * force_all_opaque() was called on the bitmap before it
@@ skipping 301 matching lines @@
 static const ConfigData gRec[] = {
     { SkBitmap::kARGB_8888_Config, kRaster_Backend, kDontCare_GLContextType,                  0, kRW_ConfigFlag,    "8888",         true },
 #if 0   // stop testing this (for now at least) since we want to remove support for it (soon please!!!)
     { SkBitmap::kARGB_4444_Config, kRaster_Backend, kDontCare_GLContextType,                  0, kRW_ConfigFlag,    "4444",         true },
 #endif
     { SkBitmap::kRGB_565_Config,   kRaster_Backend, kDontCare_GLContextType,                  0, kRW_ConfigFlag,    "565",          true },
 #if SK_SUPPORT_GPU
     { SkBitmap::kARGB_8888_Config, kGPU_Backend,    GrContextFactory::kNative_GLContextType,  0, kRW_ConfigFlag,    "gpu",          true },
     { SkBitmap::kARGB_8888_Config, kGPU_Backend,    GrContextFactory::kNative_GLContextType, 16, kRW_ConfigFlag,    "msaa16",       false},
     { SkBitmap::kARGB_8888_Config, kGPU_Backend,    GrContextFactory::kNative_GLContextType,  4, kRW_ConfigFlag,    "msaa4",        false},
-    /* The debug context does not generate images */
+    /* The gpudebug context does not generate meaningful images, so don't record
+     * the images it generates!  We only run it to look for asserts. */
     { SkBitmap::kARGB_8888_Config, kGPU_Backend,    GrContextFactory::kDebug_GLContextType,   0, kNone_ConfigFlag,  "gpudebug",     GR_DEBUG},
 #if SK_ANGLE
     { SkBitmap::kARGB_8888_Config, kGPU_Backend,    GrContextFactory::kANGLE_GLContextType,   0, kRW_ConfigFlag,    "angle",        true },
     { SkBitmap::kARGB_8888_Config, kGPU_Backend,    GrContextFactory::kANGLE_GLContextType,  16, kRW_ConfigFlag,    "anglemsaa16",  true },
 #endif // SK_ANGLE
 #ifdef SK_MESA
     { SkBitmap::kARGB_8888_Config, kGPU_Backend,    GrContextFactory::kMESA_GLContextType,    0, kRW_ConfigFlag,    "mesa",         true },
 #endif // SK_MESA
 #endif // SK_SUPPORT_GPU
 #ifdef SK_SUPPORT_XPS
@@ skipping 904 matching lines @@
     if (FLAGS_forceBWtext) {
         canvas->setDrawFilter(SkNEW(BWTextDrawFilter))->unref();
     }
 }
 
 #if !defined(SK_BUILD_FOR_IOS) && !defined(SK_BUILD_FOR_NACL)
 int main(int argc, char * const argv[]) {
     return tool_main(argc, (char**) argv);
 }
 #endif