Source/core/rendering/RenderBox.cpp - Issue 19096009: Use isHTMLTextAreaElement and toHTMLTextAreaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.cpp

Issue 19096009: Use isHTMLTextAreaElement and toHTMLTextAreaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderBox.cpp

diff --git a/Source/core/rendering/RenderBox.cpp b/Source/core/rendering/RenderBox.cpp

index 12153fe566e27d82512c247230417c7c1c459337..6c5148cfe9afc026212d2e1b7c7e1221dd1d5f56 100644

--- a/Source/core/rendering/RenderBox.cpp

+++ b/Source/core/rendering/RenderBox.cpp

@@ -35,6 +35,7 @@

#include "core/html/HTMLElement.h"

#include "core/html/HTMLFrameOwnerElement.h"

#include "core/html/HTMLHtmlElement.h"

+#include "core/html/HTMLTextAreaElement.h"

#include "core/page/Frame.h"

#include "core/page/FrameView.h"

#include "core/page/Page.h"

@@ -2281,7 +2282,8 @@ bool RenderBox::sizesLogicalWidthToFitContent(SizeType widthType) const

// stretching column flexbox.

// FIXME: Think about block-flow here.

// https://bugs.webkit.org/show_bug.cgi?id=46473

- if (logicalWidth.type() == Auto && !isStretchingColumnFlexItem(this) && node() && (node()->hasTagName(inputTag) || node()->hasTagName(selectTag) || node()->hasTagName(buttonTag) || node()->hasTagName(textareaTag) || node()->hasTagName(legendTag)))

+ if (logicalWidth.type() == Auto && !isStretchingColumnFlexItem(this) && node() && (node()->hasTagName(inputTag)

+ || node()->hasTagName(selectTag) || node()->hasTagName(buttonTag) || isHTMLTextAreaElement(node()) || node()->hasTagName(legendTag)))

return true;

if (isHorizontalWritingMode() != containingBlock()->isHorizontalWritingMode())

« no previous file with comments | « Source/core/rendering/HitTestResult.cpp ('k') | Source/core/rendering/RenderTextControlMultiLine.cpp » ('j') | no next file with comments »