Source/core/rendering/HitTestResult.cpp - Issue 19096009: Use isHTMLTextAreaElement and toHTMLTextAreaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/HitTestResult.cpp

Issue 19096009: Use isHTMLTextAreaElement and toHTMLTextAreaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/HitTestResult.cpp

diff --git a/Source/core/rendering/HitTestResult.cpp b/Source/core/rendering/HitTestResult.cpp

index 614afa8d5d6fe03fa97c3ae181362c9c58e67a98..fd72506e7ba451d2efa425f4f8c31f12b2f40bb7 100644

--- a/Source/core/rendering/HitTestResult.cpp

+++ b/Source/core/rendering/HitTestResult.cpp

@@ -34,6 +34,7 @@

#include "core/html/HTMLImageElement.h"

#include "core/html/HTMLInputElement.h"

#include "core/html/HTMLMediaElement.h"

+#include "core/html/HTMLTextAreaElement.h"

#include "core/html/HTMLVideoElement.h"

#include "core/html/parser/HTMLParserIdioms.h"

#include "core/loader/cache/CachedImage.h"

@@ -385,7 +386,7 @@ bool HitTestResult::isContentEditable() const

if (!m_innerNonSharedNode)

return false;

- if (m_innerNonSharedNode->hasTagName(textareaTag))

+ if (isHTMLTextAreaElement(m_innerNonSharedNode.get()))

return true;

if (m_innerNonSharedNode->hasTagName(inputTag))

« no previous file with comments | « Source/core/page/FocusController.cpp ('k') | Source/core/rendering/RenderBox.cpp » ('j') | no next file with comments »