Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issue 19096009: Use isHTMLTextAreaElement and toHTMLTextAreaElement (Closed)

Created:
7 years, 5 months ago by kangil_
Modified:
7 years, 5 months ago
CC:
blink-reviews, aboxhall, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, dmazzoni, apavlov+blink_chromium.org, adamk+blink_chromium.org, jchaffraix+rendering, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use isHTMLTextAreaElement and toHTMLTextAreaElement To avoid direct use of static_cast, this patch uses isHTMLHtmlElement and toHTMLHtmlElement for code cleanup. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154118

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -24 lines) Patch
M Source/core/accessibility/AccessibilityNodeObject.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/accessibility/AccessibilityRenderObject.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.h View 1 chunk +6 lines, -1 line 0 comments Download
M Source/core/page/FocusController.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTextControlMultiLine.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebFrameImpl.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/web/WebSearchableFormData.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
lgtm
7 years, 5 months ago (2013-07-12 13:33:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19096009/1
7 years, 5 months ago (2013-07-12 14:06:45 UTC) #2
commit-bot: I haz the power
Failed to apply patch for Source/core/rendering/RenderBox.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 5 months ago (2013-07-12 14:06:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19096009/4001
7 years, 5 months ago (2013-07-12 14:11:18 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_python_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=16504
7 years, 5 months ago (2013-07-12 14:27:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/19096009/4001
7 years, 5 months ago (2013-07-12 14:29:09 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-12 14:57:40 UTC) #7
Message was sent while issue was closed.
Change committed as 154118

Powered by Google App Engine
This is Rietveld 408576698