Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1909513003: Rename crypto/ *_openssl files (Closed)

Created:
4 years, 8 months ago by svaldez
Modified:
4 years, 8 months ago
Reviewers:
davidben, estark
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename crypto/ *_openssl files With the removal of most of the NSS code, we no longer need to split up code between NSS and OpenSSL implementations. BUG=604728 Committed: https://crrev.com/22de42fecbdc7d132c086dec7744033ff20af55e Cr-Commit-Position: refs/heads/master@{#388856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -1139 lines) Patch
M components/certificate_reporting/error_reporter.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/BUILD.gn View 4 chunks +9 lines, -10 lines 0 comments Download
A + crypto/aead.h View 1 chunk +1 line, -2 lines 0 comments Download
A + crypto/aead.cc View 1 chunk +1 line, -1 line 0 comments Download
D crypto/aead_openssl.h View 1 chunk +0 lines, -50 lines 0 comments Download
D crypto/aead_openssl.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D crypto/aead_openssl_unittest.cc View 1 chunk +0 lines, -50 lines 0 comments Download
A + crypto/aead_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/crypto.gyp View 1 chunk +1 line, -1 line 0 comments Download
M crypto/crypto.gypi View 3 chunks +8 lines, -9 lines 0 comments Download
A + crypto/curve25519.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D crypto/curve25519_openssl.cc View 1 chunk +0 lines, -26 lines 0 comments Download
A + crypto/ec_private_key.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D crypto/ec_private_key_openssl.cc View 1 chunk +0 lines, -226 lines 0 comments Download
M crypto/encryptor.h View 1 chunk +1 line, -1 line 0 comments Download
M crypto/encryptor.cc View 3 chunks +165 lines, -1 line 0 comments Download
D crypto/encryptor_openssl.cc View 1 chunk +0 lines, -178 lines 0 comments Download
A + crypto/rsa_private_key.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D crypto/rsa_private_key_openssl.cc View 1 chunk +0 lines, -117 lines 0 comments Download
A + crypto/secure_hash.cc View 3 chunks +6 lines, -6 lines 0 comments Download
D crypto/secure_hash_openssl.cc View 1 chunk +0 lines, -65 lines 0 comments Download
A + crypto/signature_creator.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D crypto/signature_creator_openssl.cc View 1 chunk +0 lines, -116 lines 0 comments Download
A + crypto/signature_verifier.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D crypto/signature_verifier_openssl.cc View 1 chunk +0 lines, -160 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909513003/1
4 years, 8 months ago (2016-04-20 20:38:49 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 23:21:16 UTC) #4
svaldez
4 years, 8 months ago (2016-04-21 00:27:03 UTC) #6
davidben
lgtm
4 years, 8 months ago (2016-04-21 17:39:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909513003/1
4 years, 8 months ago (2016-04-21 17:48:03 UTC) #9
svaldez
Hey, This is one of many CLs to rename things now that NSS on iOS ...
4 years, 8 months ago (2016-04-21 17:50:58 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/171511)
4 years, 8 months ago (2016-04-21 17:56:49 UTC) #13
estark
components/certificate_reporting lgtm
4 years, 8 months ago (2016-04-21 19:34:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909513003/1
4 years, 8 months ago (2016-04-21 19:36:31 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 19:42:32 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:37:53 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22de42fecbdc7d132c086dec7744033ff20af55e
Cr-Commit-Position: refs/heads/master@{#388856}

Powered by Google App Engine
This is Rietveld 408576698