Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 1910903002: Remove *_openssl files for gcm_driver (Closed)

Created:
4 years, 8 months ago by svaldez
Modified:
4 years, 8 months ago
Reviewers:
Peter Beverloo, jianli
CC:
chromium-reviews, Peter Beverloo, johnme+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove *_openssl files for gcm_driver BUG=604728 Committed: https://crrev.com/e0187a49c43ecf1d0867776c14a20f1788d76ff1 Cr-Commit-Position: refs/heads/master@{#389130}

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 1

Patch Set 3 : Rebase. #

Patch Set 4 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -166 lines) Patch
M components/gcm_driver.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/gcm_driver/crypto/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/gcm_driver/crypto/gcm_message_cryptographer.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M components/gcm_driver/crypto/gcm_message_cryptographer.cc View 3 chunks +67 lines, -0 lines 0 comments Download
D components/gcm_driver/crypto/gcm_message_cryptographer_openssl.cc View 1 chunk +0 lines, -82 lines 0 comments Download
M components/gcm_driver/crypto/p256_key_util.cc View 1 2 3 chunks +56 lines, -0 lines 0 comments Download
D components/gcm_driver/crypto/p256_key_util_openssl.cc View 1 2 1 chunk +0 lines, -79 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
svaldez
4 years, 8 months ago (2016-04-22 14:58:10 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910903002/20001
4 years, 8 months ago (2016-04-22 14:58:16 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/23613) ios_rel_device_gn on ...
4 years, 8 months ago (2016-04-22 15:00:40 UTC) #6
Peter Beverloo
lgtm, thank you for doing this! :-) (I'm the one who wrote these files.) https://codereview.chromium.org/1910903002/diff/20001/components/gcm_driver/crypto/gcm_message_cryptographer.cc ...
4 years, 8 months ago (2016-04-22 15:08:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910903002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910903002/60001
4 years, 8 months ago (2016-04-22 15:12:59 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-22 16:10:21 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:48:24 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e0187a49c43ecf1d0867776c14a20f1788d76ff1
Cr-Commit-Position: refs/heads/master@{#389130}

Powered by Google App Engine
This is Rietveld 408576698