Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1877233002: DevTools: Do not scroll the console to show the prompt when we select the console tab. (Closed)

Created:
4 years, 8 months ago by tkent
Modified:
4 years, 8 months ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Do not scroll the console to show the prompt when we select the console tab. This CL fixes a regression by the behavior change of crrev.com/360545. We'd like to avoid text selection and scrolling in focus() by setting text selection before focus(). BUG=602099 Committed: https://crrev.com/a31414c359daff0ca68381b7e9625e188cdfbfbf Cr-Commit-Position: refs/heads/master@{#386751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
lushnikov@, would you review this please?
4 years, 8 months ago (2016-04-12 05:15:34 UTC) #2
lushnikov
Thanks so much! LGTM!
4 years, 8 months ago (2016-04-12 18:31:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1877233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1877233002/1
4 years, 8 months ago (2016-04-12 18:31:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 18:37:12 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 18:39:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a31414c359daff0ca68381b7e9625e188cdfbfbf
Cr-Commit-Position: refs/heads/master@{#386751}

Powered by Google App Engine
This is Rietveld 408576698