Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1909403002: Revert of Make RenderFrameImpl own its frame blame context (Closed)

Created:
4 years, 8 months ago by Sami
Modified:
4 years, 8 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make RenderFrameImpl own its frame blame context (patchset #2 id:20001 of https://codereview.chromium.org/1907453002/ ) Reason for revert: This is causing a use-after-free: crbug.com/605480 BUG=605480 Original issue's description: > Make RenderFrameImpl own its frame blame context > > RenderFrameImpl creates the respective frame blame context, but was > mistakenly not freeing it. > > BUG=546021 TBR=jochen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=546021 Committed: https://crrev.com/aebd9e45b4f25580dc77fe706823f77e89a2865b Cr-Commit-Position: refs/heads/master@{#389104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sami
Created Revert of Make RenderFrameImpl own its frame blame context
4 years, 8 months ago (2016-04-22 13:45:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909403002/1
4 years, 8 months ago (2016-04-22 13:45:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909403002/1
4 years, 8 months ago (2016-04-22 14:01:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909403002/1
4 years, 8 months ago (2016-04-22 14:31:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 14:43:39 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:47:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aebd9e45b4f25580dc77fe706823f77e89a2865b
Cr-Commit-Position: refs/heads/master@{#389104}

Powered by Google App Engine
This is Rietveld 408576698