content/renderer/render_frame_impl.h - Issue 1909403002: Revert of Make RenderFrameImpl own its frame blame context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 1909403002: Revert of Make RenderFrameImpl own its frame blame context (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 57c67a1b3c2fe7f6c1b374da76b359fac0c714d7..eaadfa8a498251560e76a8e1ef555434f68400bd 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -1220,7 +1220,7 @@

std::unique_ptr<ExternalPopupMenu> external_popup_menu_;

#endif

- std::unique_ptr<FrameBlameContext> blame_context_;

+ FrameBlameContext* blame_context_; // Not owned.

base::WeakPtrFactory<RenderFrameImpl> weak_factory_;

« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »