Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 1909283003: Reland "Fix interpreter unittest for embedded constant pools." (Closed)

Created:
4 years, 8 months ago by MTBrandyberry
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Fix interpreter unittest for embedded constant pools." The offset from fp to the register file is based on the frame size -- which is one slot larger when embedded constant pools are enabled. TEST=unittests/DecodeBytecodeAndOperands TBR=rmcilroy@chromium.org, bmeurer@chromium.org, oth@chromium.org, mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1906963002 Cr-Commit-Position: refs/heads/master@{#35735} Committed: https://crrev.com/d0f414dbe63edbbafb4eebe5911292962c6806bc Cr-Commit-Position: refs/heads/master@{#35737}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M test/unittests/interpreter/bytecodes-unittest.cc View 4 chunks +23 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909283003/1
4 years, 8 months ago (2016-04-22 15:07:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 15:31:04 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:52 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0f414dbe63edbbafb4eebe5911292962c6806bc
Cr-Commit-Position: refs/heads/master@{#35737}

Powered by Google App Engine
This is Rietveld 408576698