Fix interpreter unittest for embedded constant pools.

Fix interpreter unittest for embedded constant pools.

The offset from fp to the register file is based on the frame size
-- which is one slot larger when embedded constant pools are enabled.

TEST=unittests/DecodeBytecodeAndOperands
R=rmcilroy@chromium.org, bmeurer@chromium.org, oth@chromium.org, mstarzinger@chromium.org
BUG=

Committed: https://crrev.com/074320ac2d29e8f4b897b58f7e82273126e92f9f
Cr-Commit-Position: refs/heads/master@{#35735}

[MTBrandyberry, 2016-04-21 20:08:03]

Description was changed from

==========
Fix interpreter unittest for embedded constant pools.

The offset from fp to the register file is based on the frame size
-- which is one slot larger when embedded constant pools are enabled.

TEST=unittests/DecodeBytecodeAndOperands
R=rmcilroy@chromium.org, bmeurer@chromium.org, oth@chromium.org,
mstarzinger@chromium.org
BUG=
==========

to

==========
Fix interpreter unittest for embedded constant pools.

The offset from fp to the register file is based on the frame size
-- which is one slot larger when embedded constant pools are enabled.

TEST=unittests/DecodeBytecodeAndOperands
R=rmcilroy@chromium.org, bmeurer@chromium.org, oth@chromium.org,
mstarzinger@chromium.org
BUG=
==========

[MTBrandyberry, 2016-04-21 20:08:35]

PTAL

[Michael Starzinger, 2016-04-22 08:41:05]

LGTM from my end, but please wait for sign-off from either Ross or Orion as
well. Thanks!

[oth, 2016-04-22 09:34:55]

On 2016/04/22 08:41:05, Michael Starzinger wrote:
> LGTM from my end, but please wait for sign-off from either Ross or Orion as
> well. Thanks!

LGTM, with optional suggestion.

Thanks!

[oth, 2016-04-22 09:35:30]

LGTM with optional suggestion.

https://codereview.chromium.org/1906963002/diff/1/test/unittests/interpreter/...
File test/unittests/interpreter/bytecodes-unittest.cc (right):

https://codereview.chromium.org/1906963002/diff/1/test/unittests/interpreter/...
test/unittests/interpreter/bytecodes-unittest.cc:183: #define REG_HI(i)
static_cast<uint8_t>((REG_OFFSET - (i)) >> 8)
An alternative would be to have two macros here:

REG8(x) defining a single 8-bit operand value.
REG16(x) defining a pair of 8-bit values representing an 16-bit register
operand.

I think this'd be more readable in the tests.

[MTBrandyberry, 2016-04-22 14:27:04]

The CQ bit was checked by mbrandy@us.ibm.com

[MTBrandyberry, 2016-04-22 14:27:05]

The patchset sent to the CQ was uploaded after l-g-t-m from oth@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1906963002/#ps20001
(title: "Introduce REG16 per comments.")

[commit-bot: I haz the power, 2016-04-22 14:27:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1906963002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1906963002/20001

[commit-bot: I haz the power, 2016-04-22 14:48:59]

Description was changed from

==========
Fix interpreter unittest for embedded constant pools.

The offset from fp to the register file is based on the frame size
-- which is one slot larger when embedded constant pools are enabled.

TEST=unittests/DecodeBytecodeAndOperands
R=rmcilroy@chromium.org, bmeurer@chromium.org, oth@chromium.org,
mstarzinger@chromium.org
BUG=
==========

to

==========
Fix interpreter unittest for embedded constant pools.

The offset from fp to the register file is based on the frame size
-- which is one slot larger when embedded constant pools are enabled.

TEST=unittests/DecodeBytecodeAndOperands
R=rmcilroy@chromium.org, bmeurer@chromium.org, oth@chromium.org,
mstarzinger@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-04-22 14:49:00]

Committed patchset #2 (id:20001)

[MTBrandyberry, 2016-04-22 14:54:23]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1916433002/ by mbrandy@us.ibm.com.

The reason for reverting is: Need to reland with proper #undef logic..

[MTBrandyberry, 2016-04-22 15:02:27]

Patchset #3 (id:40001) has been deleted

[MTBrandyberry, 2016-04-22 15:03:23]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1909323003/ by mbrandy@us.ibm.com.

The reason for reverting is: Need to fix the #undef logic..

[commit-bot: I haz the power, 2016-04-22 19:15:48]

Description was changed from

==========
Fix interpreter unittest for embedded constant pools.

The offset from fp to the register file is based on the frame size
-- which is one slot larger when embedded constant pools are enabled.

TEST=unittests/DecodeBytecodeAndOperands
R=rmcilroy@chromium.org, bmeurer@chromium.org, oth@chromium.org,
mstarzinger@chromium.org
BUG=
==========

to

==========
Fix interpreter unittest for embedded constant pools.

The offset from fp to the register file is based on the frame size
-- which is one slot larger when embedded constant pools are enabled.

TEST=unittests/DecodeBytecodeAndOperands
R=rmcilroy@chromium.org, bmeurer@chromium.org, oth@chromium.org,
mstarzinger@chromium.org
BUG=

Committed: https://crrev.com/074320ac2d29e8f4b897b58f7e82273126e92f9f
Cr-Commit-Position: refs/heads/master@{#35735}
==========

[commit-bot: I haz the power, 2016-04-22 19:15:49]

Patchset 2 (id:??) landed as
https://crrev.com/074320ac2d29e8f4b897b58f7e82273126e92f9f
Cr-Commit-Position: refs/heads/master@{#35735}