Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1909273003: Makes PhantonWindowController use ash/wm/common types (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@workspace_window_resizer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes PhantonWindowController use ash/wm/common types BUG=603369 TEST=covered by tests R=jamescook@chromium.org Committed: https://crrev.com/ef0f419e6b05cc72dee473ef7145c976dd93b930 Cr-Commit-Position: refs/heads/master@{#389299}

Patch Set 1 #

Patch Set 2 : merge 2 trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -31 lines) Patch
M ash/frame/caption_buttons/frame_size_button.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/aura/wm_window_aura.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/aura/wm_window_aura.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M ash/wm/common/wm_window.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/wm/workspace/phantom_window_controller.h View 1 chunk +7 lines, -10 lines 0 comments Download
M ash/wm/workspace/phantom_window_controller.cc View 6 chunks +20 lines, -18 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1918883002 Patch 1

Messages

Total messages: 8 (3 generated)
sky
4 years, 8 months ago (2016-04-22 16:40:32 UTC) #1
James Cook
LGTM
4 years, 8 months ago (2016-04-22 20:13:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1909273003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1909273003/20001
4 years, 8 months ago (2016-04-22 22:38:28 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-22 23:33:09 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 23:34:26 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ef0f419e6b05cc72dee473ef7145c976dd93b930
Cr-Commit-Position: refs/heads/master@{#389299}

Powered by Google App Engine
This is Rietveld 408576698