Makes Panel related classes use ash/wm/common types

Makes Panel related classes use ash/wm/common types

Specifically the layoutmanager and windowresizer implementations. And
this removes GetAuraTarget() from WmWindowResizer.

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba
Cr-Commit-Position: refs/heads/master@{#389540}

[James Cook, 2016-04-25 17:16:05]

For 5 years I have been waiting for the day I find a mistake in a piece of code
you ask me to review. Today is not that day. :-) LGTM

https://codereview.chromium.org/1918883002/diff/60001/ash/wm/panels/panel_lay...
File ash/wm/panels/panel_layout_manager.cc (right):

https://codereview.chromium.org/1918883002/diff/60001/ash/wm/panels/panel_lay...
ash/wm/panels/panel_layout_manager.cc:188: explicit
PanelCalloutWidget(wm::WmWindow* container) : background_(NULL) {
optional: NULL -> nullptr while you're here?

https://codereview.chromium.org/1918883002/diff/60001/ash/wm/panels/panel_lay...
File ash/wm/panels/panel_layout_manager.h (right):

https://codereview.chromium.org/1918883002/diff/60001/ash/wm/panels/panel_lay...
ash/wm/panels/panel_layout_manager.h:111: // Overridden from
wm::WmRootWindowControllerObserver:
super-nit: Either all the "overridden" lines should end with ":" or none

https://codereview.chromium.org/1918883002/diff/60001/ash/wm/panels/panel_lay...
ash/wm/panels/panel_layout_manager.h:116: wm::WmWindowProperty property,
Hooray for real types! :-)

[sky, 2016-04-25 18:17:58]

https://codereview.chromium.org/1918883002/diff/60001/ash/wm/panels/panel_lay...
File ash/wm/panels/panel_layout_manager.cc (right):

https://codereview.chromium.org/1918883002/diff/60001/ash/wm/panels/panel_lay...
ash/wm/panels/panel_layout_manager.cc:188: explicit
PanelCalloutWidget(wm::WmWindow* container) : background_(NULL) {
On 2016/04/25 17:16:05, James Cook wrote:
> optional: NULL -> nullptr while you're here?

Done.

https://codereview.chromium.org/1918883002/diff/60001/ash/wm/panels/panel_lay...
File ash/wm/panels/panel_layout_manager.h (right):

https://codereview.chromium.org/1918883002/diff/60001/ash/wm/panels/panel_lay...
ash/wm/panels/panel_layout_manager.h:111: // Overridden from
wm::WmRootWindowControllerObserver:
On 2016/04/25 17:16:05, James Cook wrote:
> super-nit: Either all the "overridden" lines should end with ":" or none

Done.

[sky, 2016-04-25 18:19:33]

The CQ bit was checked by sky@chromium.org

[sky, 2016-04-25 18:19:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/1918883002/#ps80001
(title: "feedback")

[commit-bot: I haz the power, 2016-04-25 18:20:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1918883002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1918883002/80001

[commit-bot: I haz the power, 2016-04-25 19:40:46]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-25 19:42:05]

Description was changed from

==========
Makes Panel related classes use ash/wm/common types

Specifically the layoutmanager and windowresizer implementations. And
this removes GetAuraTarget() from WmWindowResizer.

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Makes Panel related classes use ash/wm/common types

Specifically the layoutmanager and windowresizer implementations. And
this removes GetAuraTarget() from WmWindowResizer.

BUG=603369
TEST=covered by tests
R=jamescook@chromium.org

Committed: https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba
Cr-Commit-Position: refs/heads/master@{#389540}
==========

[commit-bot: I haz the power, 2016-04-25 19:42:06]

Patchset 5 (id:??) landed as
https://crrev.com/ad031502362573a9fe05c53c8f0776e5f7009dba
Cr-Commit-Position: refs/heads/master@{#389540}