content/browser/service_worker/service_worker_provider_host.cc - Issue 1909263002: Replace safe-bool idiom with explicit WeakPtr::operator bool()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 1909263002: Replace safe-bool idiom with explicit WeakPtr::operator bool() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_form_manager.cc ('K') | « content/browser/renderer_host/media/video_capture_manager_unittest.cc ('k') | content/renderer/media/pepper_to_video_track_adapter.cc » ('j') | device/bluetooth/bluetooth_adapter_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_provider_host.cc

diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc

index 21e0ddf6239ab50140f37c2ac4180f613cd2beca..1850fb383edd2600b1b81b7244c1f6b0b1dfbf7d 100644

--- a/content/browser/service_worker/service_worker_provider_host.cc

+++ b/content/browser/service_worker/service_worker_provider_host.cc

@@ -614,7 +614,7 @@ bool ServiceWorkerProviderHost::IsReadyToSendMessages() const {

}

bool ServiceWorkerProviderHost::IsContextAlive() {

- return context_ != NULL;

+ return !!context_;

Nico 2016/06/02 21:31:02 .

}

void ServiceWorkerProviderHost::Send(IPC::Message* message) const {