Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 1909263002: Replace safe-bool idiom with explicit WeakPtr::operator bool() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.cc
diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc
index 482f17061da1f8dbe12d3dd55a551fe98d3df338..e109dd7338fc69c2db5e494975ccee7d27243692 100644
--- a/components/password_manager/core/browser/password_form_manager.cc
+++ b/components/password_manager/core/browser/password_form_manager.cc
@@ -147,8 +147,7 @@ PasswordFormManager::PasswordFormManager(
submit_result_(kSubmitResultNotSubmitted),
form_type_(kFormTypeUnspecified),
need_to_refetch_(false) {
- DCHECK_EQ(observed_form.scheme == PasswordForm::SCHEME_HTML,
- driver != nullptr);
+ DCHECK_EQ(observed_form.scheme == PasswordForm::SCHEME_HTML, !!driver);
Nico 2016/06/02 21:31:02 no !! please
if (driver)
drivers_.push_back(driver);
}

Powered by Google App Engine
This is Rietveld 408576698