Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 1909193002: Cleanup dart:indexed_db, dart:svg, and dart:js errrors. update dart:html with extra generic methods. (Closed)

Created:
4 years, 8 months ago by Jacob
Modified:
4 years, 8 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cleanup dart:indexed_db, dart:svg, and dart:js errrors. update dart:html with extra generic methods. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/23e644d3b98daaa3ae7576ddffd44aeb3804021b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+879 lines, -1492 lines) Patch
M lib/runtime/dart_sdk.js View 67 chunks +670 lines, -922 lines 0 comments Download
M tool/input_sdk/lib/html/dart2js/html_dart2js.dart View 11 chunks +23 lines, -27 lines 0 comments Download
M tool/input_sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 8 chunks +53 lines, -34 lines 0 comments Download
M tool/input_sdk/lib/js/dart2js/js_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/lib/svg/dart2js/svg_dart2js.dart View 30 chunks +49 lines, -408 lines 0 comments Download
M tool/sdk_expected_errors.txt View 3 chunks +83 lines, -100 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
4 years, 8 months ago (2016-04-21 21:24:34 UTC) #2
vsm
lgtm
4 years, 8 months ago (2016-04-21 21:35:12 UTC) #3
Jacob
4 years, 8 months ago (2016-04-21 21:51:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
23e644d3b98daaa3ae7576ddffd44aeb3804021b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698