tool/input_sdk/lib/js/dart2js/js_dart2js.dart - Issue 1909193002: Cleanup dart:indexed_db, dart:svg, and dart:js errrors. update dart:html with extra generic methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tool/input_sdk/lib/js/dart2js/js_dart2js.dart

Issue 1909193002: Cleanup dart:indexed_db, dart:svg, and dart:js errrors. update dart:html with extra generic methods. (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tool/input_sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart ('k') | tool/input_sdk/lib/svg/dart2js/svg_dart2js.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tool/input_sdk/lib/js/dart2js/js_dart2js.dart

diff --git a/tool/input_sdk/lib/js/dart2js/js_dart2js.dart b/tool/input_sdk/lib/js/dart2js/js_dart2js.dart

index ada212291d7fb08a9a47cd8ce7341cb7116b7e1f..6fde3c644e2e76f93b7fc0667906e5bffe6f9142 100644

--- a/tool/input_sdk/lib/js/dart2js/js_dart2js.dart

+++ b/tool/input_sdk/lib/js/dart2js/js_dart2js.dart

@@ -421,7 +421,7 @@ class JsArray<E> extends JsObject with ListMixin<E> {

int length = end - start;

if (length == 0) return;

if (skipCount < 0) throw new ArgumentError(skipCount);

- var args = [start, length]..addAll(iterable.skip(skipCount).take(length));

+ var args = <Object>[start, length]..addAll(iterable.skip(skipCount).take(length));

callMethod('splice', args);

}

« no previous file with comments | « tool/input_sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart ('k') | tool/input_sdk/lib/svg/dart2js/svg_dart2js.dart » ('j') | no next file with comments »