Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1909133002: Add MGLEcho (Closed)

Created:
4 years, 8 months ago by abarth-chromium
Modified:
4 years, 8 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add MGLEcho This function is useful for measuring how far behind the service is. TBR=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a37b8c21cedc3d1b94f7be276e513cdea88e09ac

Patch Set 1 #

Patch Set 2 : deps #

Patch Set 3 : git add #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -13 lines) Patch
M gpu/command_buffer/client/gles2_implementation.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gpu_control.h View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/gles2/BUILD.gn View 1 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/gles2/control_thunks_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/gles2/control_thunks_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/gles2/gles2_context.h View 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/gles2/gles2_context.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M mojo/gles2/mgl_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/c/gpu/BUILD.gn View 2 chunks +11 lines, -1 line 0 comments Download
A mojo/public/c/gpu/MGL/mgl_echo.h View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M mojo/public/platform/native/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A mojo/public/platform/native/mgl_echo_thunks.h View 1 2 1 chunk +47 lines, -0 lines 0 comments Download
A mojo/public/platform/native/mgl_echo_thunks.c View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
M shell/native_application_support.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
abarth-chromium
4 years, 8 months ago (2016-04-21 20:22:04 UTC) #1
abarth-chromium
Committed patchset #3 (id:40001) manually as a37b8c21cedc3d1b94f7be276e513cdea88e09ac (presubmit successful).
4 years, 8 months ago (2016-04-21 20:46:43 UTC) #4
jamesr
4 years, 8 months ago (2016-04-21 22:00:25 UTC) #5
Message was sent while issue was closed. 
lgtm

i think we'll want to rename this down the line

Powered by Google App Engine
This is Rietveld 408576698