Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: extensions/common/url_pattern_set.cc

Issue 1908953003: Convert //extensions/{common,shell} from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase? Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/url_pattern_set.h ('k') | extensions/common/url_pattern_set_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/url_pattern_set.cc
diff --git a/extensions/common/url_pattern_set.cc b/extensions/common/url_pattern_set.cc
index 5f09564f9f41bdf703746c041bef028a69ebd20f..8a2de4a76d1a536030a28046ec1b20136ce3f510 100644
--- a/extensions/common/url_pattern_set.cc
+++ b/extensions/common/url_pattern_set.cc
@@ -229,8 +229,8 @@ bool URLPatternSet::OverlapsWith(const URLPatternSet& other) const {
return false;
}
-scoped_ptr<base::ListValue> URLPatternSet::ToValue() const {
- scoped_ptr<base::ListValue> value(new base::ListValue);
+std::unique_ptr<base::ListValue> URLPatternSet::ToValue() const {
+ std::unique_ptr<base::ListValue> value(new base::ListValue);
for (URLPatternSet::const_iterator i = patterns_.begin();
i != patterns_.end(); ++i)
value->AppendIfNotPresent(new base::StringValue(i->GetAsString()));
@@ -262,8 +262,9 @@ bool URLPatternSet::Populate(const std::vector<std::string>& patterns,
return true;
}
-scoped_ptr<std::vector<std::string> > URLPatternSet::ToStringVector() const {
- scoped_ptr<std::vector<std::string> > value(new std::vector<std::string>);
+std::unique_ptr<std::vector<std::string>> URLPatternSet::ToStringVector()
+ const {
+ std::unique_ptr<std::vector<std::string>> value(new std::vector<std::string>);
for (URLPatternSet::const_iterator i = patterns_.begin();
i != patterns_.end();
++i) {
« no previous file with comments | « extensions/common/url_pattern_set.h ('k') | extensions/common/url_pattern_set_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698