DevTools: Introduce eslint configuration.

DevTools: Introduce eslint configuration.

We'll also remove jscs with this change

BUG=605878
Committed: https://crrev.com/03a223eedbd93d09914166fd9997c7d50049daa0
Cr-Commit-Position: refs/heads/master@{#389215}

[paulirish, 2016-04-21 07:51:34]

paulirish@chromium.org changed reviewers:
+ jonathan.garbee@chromium.org, kdzwinel@gmail.com, pbakaus@chromium.org,
samccone@google.com

[paulirish, 2016-04-21 07:51:34]

A good starting point for eslint configuration for devtools, I'd say.

The results across the current ToT with this configuration:
https://dl.dropboxusercontent.com/u/39519/rm-someday/devtools-eslintoutput.html

I've refined it quite a bit, and the remaining ~250 errors all seem to be legit
style issues.

Does the config and results look all good to ya'll?

[pbakaus, 2016-04-21 23:04:43]

lgtm

[Jonathan Garbee, 2016-04-21 23:30:57]

On 2016/04/21 at 23:04:43, pbakaus wrote:
> lgtm

LGTM

Love this, thanks for putting the work in to it!

[kdzwinel, 2016-04-21 23:35:10]

On 2016/04/21 at 23:30:57, jonathan.garbee wrote:
> On 2016/04/21 at 23:04:43, pbakaus wrote:
> > lgtm
> 
> LGTM
> 
> Love this, thanks for putting the work in to it!

Awesome 👍 Stats for remaining errors: http://i.imgur.com/XY9iDLk.png

[caseq, 2016-04-21 23:38:23]

caseq@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2016-04-21 23:38:23]

Should we disable "Empty block statement" aka no-empty? We intentionally use
these for for/while loops that have empty body, i.e. for (...) {} instead of
just for (...);

[paulirish, 2016-04-22 09:35:26]

On 2016/04/21 at 23:38:23, caseq wrote:
> Should we disable "Empty block statement" aka no-empty? We intentionally use
these for for/while loops that have empty body, i.e. for (...) {} instead of
just for (...);

Played around with this and we don't need the no-empty rule, so it's gone. Made
a few other tweaks. 

Separate CL incoming to fix the remaining style issues.

[paulirish, 2016-04-22 09:40:58]

The CQ bit was checked by paulirish@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 09:41:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908863002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908863002/20001

[paulirish, 2016-04-22 09:47:35]

Description was changed from

==========
DevTools: Introduce eslint configuration.

We'll also remove jscs with this change

BUG=none
==========

to

==========
DevTools: Introduce eslint configuration.

We'll also remove jscs with this change

BUG=605878
==========

[paulirish, 2016-04-22 09:48:11]

PTAL

FWIW, I've fixed all the remaining issues in
https://codereview.chromium.org/1907263002

[commit-bot: I haz the power, 2016-04-22 10:49:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 10:49:15]

Dry run: This issue passed the CQ dry run.

[pfeldman, 2016-04-22 14:18:14]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2016-04-22 14:18:15]

lgtm

[paulirish, 2016-04-22 18:30:17]

The CQ bit was checked by paulirish@chromium.org

[paulirish, 2016-04-22 18:30:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
jonathan.garbee@chromium.org, pbakaus@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1908863002/#ps40001
(title: "better inline docs.")

[commit-bot: I haz the power, 2016-04-22 18:32:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908863002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908863002/40001

[commit-bot: I haz the power, 2016-04-22 19:52:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 20:00:05]

Description was changed from

==========
DevTools: Introduce eslint configuration.

We'll also remove jscs with this change

BUG=605878
==========

to

==========
DevTools: Introduce eslint configuration.

We'll also remove jscs with this change

BUG=605878

Committed: https://crrev.com/03a223eedbd93d09914166fd9997c7d50049daa0
Cr-Commit-Position: refs/heads/master@{#389215}
==========

[commit-bot: I haz the power, 2016-04-22 20:00:07]

Patchset 3 (id:??) landed as
https://crrev.com/03a223eedbd93d09914166fd9997c7d50049daa0
Cr-Commit-Position: refs/heads/master@{#389215}