Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1908753002: Roll src/third_party/boringssl/src 0fe4d8bef..f01fb5dc0 (Closed)

Created:
4 years, 8 months ago by davidben
Modified:
4 years, 8 months ago
Reviewers:
svaldez, eroman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix webcrypto #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/webcrypto/algorithms/sha.cc View 1 2 chunks +5 lines, -5 lines 1 comment Download

Messages

Total messages: 16 (8 generated)
davidben
4 years, 8 months ago (2016-04-20 23:13:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908753002/1
4 years, 8 months ago (2016-04-20 23:14:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/201078)
4 years, 8 months ago (2016-04-20 23:53:52 UTC) #7
davidben
+eroman for webcrypto https://codereview.chromium.org/1908753002/diff/20001/components/webcrypto/algorithms/sha.cc File components/webcrypto/algorithms/sha.cc (right): https://codereview.chromium.org/1908753002/diff/20001/components/webcrypto/algorithms/sha.cc#newcode93 components/webcrypto/algorithms/sha.cc:93: DCHECK_LE(hash_expected_size, static_cast<unsigned>(EVP_MAX_MD_SIZE)); This is kind of ...
4 years, 8 months ago (2016-04-21 00:17:09 UTC) #9
eroman
lgtm
4 years, 8 months ago (2016-04-21 01:23:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908753002/20001
4 years, 8 months ago (2016-04-21 16:08:14 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 16:32:39 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:35:13 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/31fe1233aed27affb741984db8903df127163981
Cr-Commit-Position: refs/heads/master@{#388787}

Powered by Google App Engine
This is Rietveld 408576698