Roll src/third_party/boringssl/src 0fe4d8bef..f01fb5dc0

components/webcrypto/algorithms/sha.cc

Index: components/webcrypto/algorithms/sha.cc
diff --git a/components/webcrypto/algorithms/sha.cc b/components/webcrypto/algorithms/sha.cc
index 4c4b47ba18bec94977a7cbd638d866f8ad2fccd9..a210fb146f5304486aeef613dfa26e401acdbfed 100644
--- a/components/webcrypto/algorithms/sha.cc
+++ b/components/webcrypto/algorithms/sha.cc
@@ -56,7 +56,7 @@ class DigestorImpl : public blink::WebCryptoDigestor {
   }
 
   Status FinishWithVectorAndStatus(std::vector<uint8_t>* result) {
-    const int hash_expected_size = EVP_MD_CTX_size(digest_context_.get());
+    const size_t hash_expected_size = EVP_MD_CTX_size(digest_context_.get());
     result->resize(hash_expected_size);
     unsigned int hash_buffer_size;  // ignored
     return FinishInternal(result->data(), &hash_buffer_size);
@@ -87,13 +87,13 @@ class DigestorImpl : public blink::WebCryptoDigestor {
     if (!error.IsSuccess())
       return error;
 
-    const int hash_expected_size = EVP_MD_CTX_size(digest_context_.get());
-    if (hash_expected_size <= 0)
+    const size_t hash_expected_size = EVP_MD_CTX_size(digest_context_.get());
+    if (hash_expected_size == 0)
       return Status::ErrorUnexpected();
-    DCHECK_LE(hash_expected_size, EVP_MAX_MD_SIZE);
+    DCHECK_LE(hash_expected_size, static_cast<unsigned>(EVP_MAX_MD_SIZE));

[davidben, 2016/04/21 00:17:09]

This is kind of depressing. :-/ EVP_MAX_MD_SIZE is an untyped macro. I can see
about adding a 'u' suffix to it at some point, though I worry that might break
other compiles.

 
     if (!EVP_DigestFinal_ex(digest_context_.get(), result, result_size) ||
-        static_cast<int>(*result_size) != hash_expected_size)
+        *result_size != hash_expected_size)
       return Status::OperationError();
 
     return Status::Success();