Add instructions for building with MSAN

Add instructions for building with MSAN

Move static functions only used by GPU into if SK_SUPPORT_GPU guard.
This enables building MSAN, which seems to default to not supporting
GPU.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1908493002
DOCS_PREVIEW= https://skia.org/?cl=1908493002

Committed: https://skia.googlesource.com/skia/+/9d08172828c2119752bc5bceeb1084c02ce7ab33

[scroggo, 2016-04-20 14:34:33]

Description was changed from

==========
Add instructions for building with MSAN

Move static functions only used by GPU into if SK_SUPPORT_GPU guard.
This enables building MSAN, which seems to default to not supporting
GPU.
==========

to

==========
Add instructions for building with MSAN

Move static functions only used by GPU into if SK_SUPPORT_GPU guard.
This enables building MSAN, which seems to default to not supporting
GPU.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
DOCS_PREVIEW= https://skia.org/?cl=1908493002
==========

[scroggo, 2016-04-20 14:39:09]

scroggo@google.com changed reviewers:
+ halcanary@google.com, mtklein@google.com

[scroggo, 2016-04-20 14:39:10]

https://codereview.chromium.org/1908493002/diff/1/site/user/special/msan.md
File site/user/special/msan.md (right):

https://codereview.chromium.org/1908493002/diff/1/site/user/special/msan.md#n...
site/user/special/msan.md:1: Running with Memory Sanitizer
I'm not very familiar with markdown, so the format is pretty basic. I'm open to
suggestions.

The instructions are also pretty basic. They are borrowed from
crrev.com/1665823002.

[hal.canary, 2016-04-20 14:45:43]

https://codereview.chromium.org/1908493002/diff/1/site/user/special/msan.md
File site/user/special/msan.md (right):

https://codereview.chromium.org/1908493002/diff/1/site/user/special/msan.md#n...
site/user/special/msan.md:1: Running with Memory Sanitizer
On 2016/04/20 14:39:10, scroggo wrote:
> I'm not very familiar with markdown, so the format is pretty basic. I'm open
to
> suggestions.
> 
> The instructions are also pretty basic. They are borrowed from
> crrev.com/1665823002.

The msan build builds Clang from scratch, so you need to download Clang first:

Add the following to your gclient file:

    target_os = ['llvm']

Then run:

    gclient sync

Build
-----

    out/Debug/dm -v --match ~Codec ~BlurLargeImage ~FontMgrAndroidParser
Run
---

    out/Debug/dm -v --match ~Codec ~BlurLargeImage ~FontMgrAndroidParser

[mtklein, 2016-04-20 14:45:45]

lgtm

[hal.canary, 2016-04-20 14:48:11]

https://codereview.chromium.org/1908493002/diff/1/site/user/special/msan.md
File site/user/special/msan.md (right):

https://codereview.chromium.org/1908493002/diff/1/site/user/special/msan.md#n...
site/user/special/msan.md:13: $ gclient sync
Run it this way instead:

    bin/sync-and-gyp --deps=llvm

[scroggo, 2016-04-20 15:01:53]

Patchset #2 (id:20001) has been deleted

[scroggo, 2016-04-20 15:02:19]

https://codereview.chromium.org/1908493002/diff/1/site/user/special/msan.md
File site/user/special/msan.md (right):

https://codereview.chromium.org/1908493002/diff/1/site/user/special/msan.md#n...
site/user/special/msan.md:1: Running with Memory Sanitizer
On 2016/04/20 14:45:43, Hal Canary wrote:
> On 2016/04/20 14:39:10, scroggo wrote:
> > I'm not very familiar with markdown, so the format is pretty basic. I'm open
> to
> > suggestions.
> > 
> > The instructions are also pretty basic. They are borrowed from
> > crrev.com/1665823002.
> 
> The msan build builds Clang from scratch, so you need to download Clang first:
> 
> Add the following to your gclient file:
> 
>     target_os = ['llvm']
> 
> Then run:
> 
>     gclient sync
> 
> Build
> -----
> 
>     out/Debug/dm -v --match ~Codec ~BlurLargeImage ~FontMgrAndroidParser
> Run
> ---
> 
>     out/Debug/dm -v --match ~Codec ~BlurLargeImage ~FontMgrAndroidParser

It looks like you're recommending
- four spaces before commands
- no "$"
- no "./"
?

Done. FWIW, our other docs don't seem to be consistent about using a "$".

https://codereview.chromium.org/1908493002/diff/1/site/user/special/msan.md#n...
site/user/special/msan.md:13: $ gclient sync
On 2016/04/20 14:48:11, Hal Canary wrote:
> Run it this way instead:
> 
>     bin/sync-and-gyp --deps=llvm

Done.

[scroggo, 2016-04-20 15:17:57]

The CQ bit was checked by scroggo@google.com

[scroggo, 2016-04-20 15:17:57]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1908493002/#ps40001
(title: "Respond to Hal's comments")

[commit-bot: I haz the power, 2016-04-20 15:18:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1908493002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1908493002/40001

[hal.canary, 2016-04-20 15:18:51]

lgtm

[commit-bot: I haz the power, 2016-04-20 15:27:21]

Description was changed from

==========
Add instructions for building with MSAN

Move static functions only used by GPU into if SK_SUPPORT_GPU guard.
This enables building MSAN, which seems to default to not supporting
GPU.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
DOCS_PREVIEW= https://skia.org/?cl=1908493002
==========

to

==========
Add instructions for building with MSAN

Move static functions only used by GPU into if SK_SUPPORT_GPU guard.
This enables building MSAN, which seems to default to not supporting
GPU.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
DOCS_PREVIEW= https://skia.org/?cl=1908493002

Committed:
https://skia.googlesource.com/skia/+/9d08172828c2119752bc5bceeb1084c02ce7ab33
==========

[commit-bot: I haz the power, 2016-04-20 15:27:22]

Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/9d08172828c2119752bc5bceeb1084c02ce7ab33