Issue 1906893002: Building up "Fixes for SkRWBuffer"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1906893002: Building up "Fixes for SkRWBuffer" (Closed)

Created:
4 years, 8 months ago by scroggo

Modified:
4 years, 8 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@msan

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Building up "Fixes for SkRWBuffer" crrev.com/1871953002 is failing on MSAN, so I am piecemeal adding pieces to find out why it's failing. Step one is the test, which locally is not causing a problem. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1906893002

Patch Set 1 #

Patch Set 2 : Make it safe to use an empty SkROBuffer #

Patch Set 3 : Try modifying the test #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -16 lines)			Patch
	M	src/core/SkRWBuffer.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/DataRefTest.cpp	View	1 2	3 chunks	+41 lines, -15 lines	0 comments	Download

Depends on Patchset:

Issue 1908493002 Patch 40001

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scroggo

4 years, 8 months ago (2016-04-21 18:25:57 UTC) #1

Description was changed from

==========
Building up "Fixes for SkRWBuffer"

crrev.com/1871953002 is failing on MSAN, so I am piecemeal adding
pieces to find out why it's failing. Step one is the test, which
locally is not causing a problem.
==========

to

==========
Building up "Fixes for SkRWBuffer"

crrev.com/1871953002 is failing on MSAN, so I am piecemeal adding
pieces to find out why it's failing. Step one is the test, which
locally is not causing a problem.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages