Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1908473002: Split //ui/events/devices into two targets. (Closed)

Created:
4 years, 8 months ago by kylechar
Modified:
4 years, 8 months ago
Reviewers:
sadrul, sky, no sievers
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, sadrul, tdresser+watch_chromium.org, Peter Beverloo, tfarina, jam, darin-cc_chromium.org, kalyank, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split //ui/events/devices into two targets. Split /ui/events/devices into //ui/events/devices + //ui/events/devices/x11 to keep X11 code in a different component. Also udpate GYP targets in a similar fashion. Update some dependent targets and fix a few GN check problems that crop up because GN check doesn't fully understand #if defined(USE_X11) and includes. Originally commited at r388472 and reverted at r388474. There were missing deps in the GN Chrome OS X11 non-Ozone component build that I missed. Nothing in the CQ runs that configuration but it made a waterfall bot fail. TBR=sky@chromium.org,sievers@chromium.org BUG=588026 Committed: https://crrev.com/ad7148777cc4714145ef66b1b60df7e000ca9f22 Cr-Commit-Position: refs/heads/master@{#388510}

Patch Set 1 #

Patch Set 2 : More deps on new target. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -50 lines) Patch
M ash/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ash/ash.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ash/shell/content/client/shell_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_hud_debug.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_shell.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/aura.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/BUILD.gn View 2 chunks +6 lines, -1 line 0 comments Download
M ui/base/ui_base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/BUILD.gn View 3 chunks +3 lines, -1 line 0 comments Download
M ui/events/devices/BUILD.gn View 2 chunks +0 lines, -21 lines 0 comments Download
M ui/events/devices/events_devices.gyp View 1 chunk +0 lines, -15 lines 0 comments Download
A ui/events/devices/x11/BUILD.gn View 1 chunk +32 lines, -0 lines 0 comments Download
M ui/events/devices/x11/device_data_manager_x11.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/events/devices/x11/device_list_cache_x11.h View 2 chunks +2 lines, -2 lines 0 comments Download
A ui/events/devices/x11/events_devices_x11.gyp View 1 chunk +38 lines, -0 lines 0 comments Download
A ui/events/devices/x11/events_devices_x11_export.h View 1 chunk +29 lines, -0 lines 0 comments Download
M ui/events/devices/x11/touch_factory_x11.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/events.gyp View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/events/events_unittests.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/platform/x11/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/platform/x11/x11_events_platform.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/x/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/events/x/events_x.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/platform_window/x11/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/platform_window/x11/x11_window.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/wm/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/wm/core/compound_event_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/wm.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908473002/20001
4 years, 8 months ago (2016-04-20 13:51:46 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 14:54:21 UTC) #5
kylechar
Second try with fixed deps for GN Chrome OS X11 non-Ozone component build.
4 years, 8 months ago (2016-04-20 15:29:28 UTC) #8
sadrul
I assume patchset-1 is the original CL that landed, and patchset-2 includes the fixes? lgtm
4 years, 8 months ago (2016-04-20 15:59:26 UTC) #9
kylechar
Yep, that's correct. Added TBR sky@chromium.org and sievers@chromium.org for the same parts as last time.
4 years, 8 months ago (2016-04-20 16:03:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908473002/20001
4 years, 8 months ago (2016-04-20 16:04:21 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-20 16:10:01 UTC) #14
sky
SLGTM
4 years, 8 months ago (2016-04-20 19:39:56 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:23:59 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad7148777cc4714145ef66b1b60df7e000ca9f22
Cr-Commit-Position: refs/heads/master@{#388510}

Powered by Google App Engine
This is Rietveld 408576698