Remove X11 deps from //ui/events:events_base.

Remove X11 deps from //ui/events:events_base.

Split out X11 keycode related code from //ui/events:events_base. Add new
targets for XKB and X keycode manipulation.i

Update GYP in similar fashion to GN. Also fix GN check problems that
crop up because GN check doesn't fully understand #if defined(USE_X11)
and includes.

BUG=588026
TBR=watk@chromium.org

Committed: https://crrev.com/9d0b7792b0761d08442dd8c84fb0086ddac42de1
Cr-Commit-Position: refs/heads/master@{#388894}

[kylechar, 2016-04-14 20:24:57]

kylechar@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2016-04-19 14:20:16]

LGTM (sorry about sitting on this for so long)

https://codereview.chromium.org/1880313004/diff/80001/ui/events/keycodes/BUIL...
File ui/events/keycodes/BUILD.gn (right):

https://codereview.chromium.org/1880313004/diff/80001/ui/events/keycodes/BUIL...
ui/events/keycodes/BUILD.gn:23: component("x") {
Call this x11?

[kylechar, 2016-04-19 15:14:25]

Thanks! Changed the target name in GYP and GN.

https://codereview.chromium.org/1880313004/diff/80001/ui/events/keycodes/BUIL...
File ui/events/keycodes/BUILD.gn (right):

https://codereview.chromium.org/1880313004/diff/80001/ui/events/keycodes/BUIL...
ui/events/keycodes/BUILD.gn:23: component("x") {
On 2016/04/19 14:20:16, sadrul wrote:
> Call this x11?

Done.

[kylechar, 2016-04-19 15:23:40]

The CQ bit was checked by kylechar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-19 15:23:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880313004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880313004/100001

[commit-bot: I haz the power, 2016-04-19 15:35:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 15:35:13]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[kylechar, 2016-04-19 17:36:35]

kylechar@chromium.org changed reviewers:
+ reveman@chromium.org, sky@chromium.org, watk@chromium.org

[kylechar, 2016-04-19 17:36:36]

+reveman for components/exo/wayland/*, +watk for media/*, +sky for chrome/*

[sky, 2016-04-19 19:13:12]

LGTM

[kylechar, 2016-04-21 13:03:33]

Hoping to get this submitted today. Any chance you can take a look watk@ and
reveman@?

[reveman, 2016-04-21 14:38:33]

lgtm

[kylechar, 2016-04-21 18:14:37]

Description was changed from

==========
Remove X11 deps from //ui/events:events_base.

Split out X11 keycode related code from //ui/events:events_base. Add new
targets for XKB and X keycode manipulation.i

Update GYP in similar fashion to GN. Also fix GN check problems that
crop up because GN check doesn't fully understand #if defined(USE_X11)
and includes.

BUG=588026
==========

to

==========
Remove X11 deps from //ui/events:events_base.

Split out X11 keycode related code from //ui/events:events_base. Add new
targets for XKB and X keycode manipulation.i

Update GYP in similar fashion to GN. Also fix GN check problems that
crop up because GN check doesn't fully understand #if defined(USE_X11)
and includes.

BUG=588026
TBR=watk@chromium.org
==========

[kylechar, 2016-04-21 18:15:48]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-04-21 18:15:49]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
sky@chromium.org, reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/1880313004/#ps140001
(title: "Rebase.")

[kylechar, 2016-04-21 18:16:20]

Rebased and adding watk as TBR.

[commit-bot: I haz the power, 2016-04-21 18:16:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880313004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880313004/140001

[commit-bot: I haz the power, 2016-04-21 18:37:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 18:37:28]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[watk, 2016-04-21 18:43:55]

On 2016/04/21 18:16:32, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1880313004/140001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1880313004/140001

sorry! lgtm

[kylechar, 2016-04-21 19:11:49]

The CQ bit was checked by kylechar@chromium.org

[kylechar, 2016-04-21 19:11:50]

The patchset sent to the CQ was uploaded after l-g-t-m from watk@chromium.org,
reveman@chromium.org, sadrul@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1880313004/#ps160001
(title: "Fix bad rebase.")

[commit-bot: I haz the power, 2016-04-21 19:12:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880313004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880313004/160001

[commit-bot: I haz the power, 2016-04-21 21:03:20]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-04-22 19:39:17]

Description was changed from

==========
Remove X11 deps from //ui/events:events_base.

Split out X11 keycode related code from //ui/events:events_base. Add new
targets for XKB and X keycode manipulation.i

Update GYP in similar fashion to GN. Also fix GN check problems that
crop up because GN check doesn't fully understand #if defined(USE_X11)
and includes.

BUG=588026
TBR=watk@chromium.org
==========

to

==========
Remove X11 deps from //ui/events:events_base.

Split out X11 keycode related code from //ui/events:events_base. Add new
targets for XKB and X keycode manipulation.i

Update GYP in similar fashion to GN. Also fix GN check problems that
crop up because GN check doesn't fully understand #if defined(USE_X11)
and includes.

BUG=588026
TBR=watk@chromium.org

Committed: https://crrev.com/9d0b7792b0761d08442dd8c84fb0086ddac42de1
Cr-Commit-Position: refs/heads/master@{#388894}
==========

[commit-bot: I haz the power, 2016-04-22 19:39:19]

Patchset 9 (id:??) landed as
https://crrev.com/9d0b7792b0761d08442dd8c84fb0086ddac42de1
Cr-Commit-Position: refs/heads/master@{#388894}