Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1908313003: Shows the error message while fetching the SW script in the DevTools console. (Closed)

Created:
4 years, 8 months ago by horo
Modified:
4 years, 7 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, mlamouri+watch-content_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, blink-reviews, dglazkov+blink, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, horo+watch_chromium.org, kinuko+watch, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shows the error message while fetching the SW script in the DevTools console. This cl introduces EmbeddedWorkerMsg_AddMessageToConsole IPC message. The browser process sends this message to the renderer to add message to the devtools console. This behavior is similar to FrameMsg_AddMessageToConsole. BUG=605817 Committed: https://crrev.com/7498e14b76230504cc034eb6ee268eea5d91906d Cr-Commit-Position: refs/heads/master@{#389415}

Patch Set 1 #

Total comments: 2

Patch Set 2 : incorporated falken's comment #

Total comments: 2

Patch Set 3 : incorporated falken's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -11 lines) Patch
M content/browser/service_worker/embedded_worker_instance.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job.cc View 1 2 2 chunks +11 lines, -11 lines 0 comments Download
M content/common/service_worker/embedded_worker_messages.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_dispatcher.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_dispatcher.cc View 3 chunks +30 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 3 chunks +26 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebEmbeddedWorker.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (10 generated)
horo
falken@ Could you please review this?
4 years, 8 months ago (2016-04-22 08:07:43 UTC) #3
falken
Looks good. What happens when you do register() and the script response is bad? I ...
4 years, 8 months ago (2016-04-22 08:34:18 UTC) #4
horo
We will see three messages when register() failed. 1. "The script has an unsupported MIME ...
4 years, 8 months ago (2016-04-22 09:22:31 UTC) #5
horo
We will see three messages when register() failed. 1. "The script has an unsupported MIME ...
4 years, 8 months ago (2016-04-22 09:22:57 UTC) #6
falken
lgtm https://codereview.chromium.org/1908313003/diff/20001/content/browser/service_worker/service_worker_write_to_cache_job.cc File content/browser/service_worker/service_worker_write_to_cache_job.cc (right): https://codereview.chromium.org/1908313003/diff/20001/content/browser/service_worker/service_worker_write_to_cache_job.cc#newcode451 content/browser/service_worker/service_worker_write_to_cache_job.cc:451: // worker stops soon after recieving the error ...
4 years, 8 months ago (2016-04-22 09:39:53 UTC) #7
horo
Thank you. https://codereview.chromium.org/1908313003/diff/20001/content/browser/service_worker/service_worker_write_to_cache_job.cc File content/browser/service_worker/service_worker_write_to_cache_job.cc (right): https://codereview.chromium.org/1908313003/diff/20001/content/browser/service_worker/service_worker_write_to_cache_job.cc#newcode451 content/browser/service_worker/service_worker_write_to_cache_job.cc:451: // worker stops soon after recieving the ...
4 years, 8 months ago (2016-04-22 10:55:22 UTC) #8
horo
pfeldman@ Could you please review third_party/WebKit/*?
4 years, 8 months ago (2016-04-22 10:56:41 UTC) #10
pfeldman
It is unclear in which console you intend to show the message. Do you want ...
4 years, 8 months ago (2016-04-22 14:32:07 UTC) #11
pfeldman
lgtm, but i wonder if something should be done for the post-mortem case.
4 years, 8 months ago (2016-04-22 14:33:46 UTC) #12
horo
On 2016/04/22 14:33:46, pfeldman wrote: > lgtm, but i wonder if something should be done ...
4 years, 7 months ago (2016-04-25 02:25:24 UTC) #13
horo
wfh@ Could you please review content/common/service_worker/embedded_worker_messages.h?
4 years, 7 months ago (2016-04-25 02:26:14 UTC) #15
Will Harris
On 2016/04/25 02:26:14, horo wrote: > wfh@ > Could you please review > content/common/service_worker/embedded_worker_messages.h? lgtm ...
4 years, 7 months ago (2016-04-25 04:08:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908313003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908313003/40001
4 years, 7 months ago (2016-04-25 04:27:56 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-25 05:52:53 UTC) #23
commit-bot: I haz the power
4 years, 7 months ago (2016-04-25 05:53:55 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7498e14b76230504cc034eb6ee268eea5d91906d
Cr-Commit-Position: refs/heads/master@{#389415}

Powered by Google App Engine
This is Rietveld 408576698