content/common/service_worker/embedded_worker_messages.h - Issue 1908313003: Shows the error message while fetching the SW script in the DevTools console.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/embedded_worker_messages.h

Issue 1908313003: Shows the error message while fetching the SW script in the DevTools console. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: incorporated falken's comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_write_to_cache_job.cc ('k') | content/renderer/service_worker/embedded_worker_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/service_worker/embedded_worker_messages.h

diff --git a/content/common/service_worker/embedded_worker_messages.h b/content/common/service_worker/embedded_worker_messages.h

index 86fb48c8507a48990006e68681cea149fcf19f59..a245c4e007185a1c9da06593622675c5b5b4b306 100644

--- a/content/common/service_worker/embedded_worker_messages.h

+++ b/content/common/service_worker/embedded_worker_messages.h

@@ -9,6 +9,7 @@

#include <string>

#include "content/common/service_worker/embedded_worker_settings.h"

+#include "content/public/common/console_message_level.h"

#include "content/public/common/web_preferences.h"

#include "ipc/ipc_message.h"

#include "ipc/ipc_message_macros.h"

@@ -62,6 +63,12 @@ IPC_MESSAGE_CONTROL1(EmbeddedWorkerMsg_ResumeAfterDownload,

IPC_MESSAGE_CONTROL1(EmbeddedWorkerMsg_StopWorker,

int /* embedded_worker_id */)

+// Browser -> Renderer message to add message to the devtools console.

+IPC_MESSAGE_CONTROL3(EmbeddedWorkerMsg_AddMessageToConsole,

+ int /* embedded_worker_id */,

+ content::ConsoleMessageLevel /* level */,

+ std::string /* message */)

// Renderer -> Browser message to indicate that the worker is ready for

// inspection.

IPC_MESSAGE_CONTROL1(EmbeddedWorkerHostMsg_WorkerReadyForInspection,