build/android/pylib/gtest/gtest_test_instance.py - Issue 1908253006: Revert of Generate Android .isolate files used for test()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/gtest/gtest_test_instance.py

Issue 1908253006: Revert of Generate Android .isolate files used for test()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/gtest/gtest_test_instance.py

diff --git a/build/android/pylib/gtest/gtest_test_instance.py b/build/android/pylib/gtest/gtest_test_instance.py

index 640b84d088e8dfb6bf077b58794c6eaccf84084e..0a076c6fa96dd29cb0847b6e861cdcc4a45d5c75 100644

--- a/build/android/pylib/gtest/gtest_test_instance.py

+++ b/build/android/pylib/gtest/gtest_test_instance.py

@@ -12,7 +12,6 @@

from pylib.constants import host_paths

from pylib.base import base_test_result

from pylib.base import test_instance

-from pylib.utils import isolator

with host_paths.SysPath(host_paths.BUILD_COMMON_PATH):

import unittest_util # pylint: disable=import-error

@@ -198,8 +197,7 @@

args.isolate_file_path = os.path.join(

host_paths.DIR_SOURCE_ROOT, default_isolate_file_path)

- if (args.isolate_file_path and

- not isolator.IsIsolateEmpty(args.isolate_file_path)):

+ if args.isolate_file_path:

self._isolate_abs_path = os.path.abspath(args.isolate_file_path)

self._isolate_delegate = isolate_delegate

self._isolated_abs_path = os.path.join(

« no previous file with comments | « android_webview/test/BUILD.gn ('k') | build/android/pylib/instrumentation/instrumentation_test_instance.py » ('j') | no next file with comments »