build/android/pylib/instrumentation/instrumentation_test_instance.py - Issue 1908253006: Revert of Generate Android .isolate files used for test()s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/instrumentation/instrumentation_test_instance.py

Issue 1908253006: Revert of Generate Android .isolate files used for test()s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/instrumentation/instrumentation_test_instance.py

diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance.py b/build/android/pylib/instrumentation/instrumentation_test_instance.py

index 9f1e439ca0b1bfd4fd3209857719044ceab423c9..e9c33f1c544c7fc9fbac1fc0092b8d9cea6f69a8 100644

--- a/build/android/pylib/instrumentation/instrumentation_test_instance.py

+++ b/build/android/pylib/instrumentation/instrumentation_test_instance.py

@@ -17,7 +17,6 @@

from pylib.constants import host_paths

from pylib.instrumentation import test_result

from pylib.instrumentation import instrumentation_parser

-from pylib.utils import isolator

from pylib.utils import proguard

with host_paths.SysPath(host_paths.BUILD_COMMON_PATH):

@@ -293,8 +292,7 @@

def _initializeDataDependencyAttributes(self, args, isolate_delegate):

self._data_deps = []

- if (args.isolate_file_path and

- not isolator.IsIsolateEmpty(args.isolate_file_path)):

+ if args.isolate_file_path:

if os.path.isabs(args.isolate_file_path):

self._isolate_abs_path = args.isolate_file_path

else:

« no previous file with comments | « build/android/pylib/gtest/gtest_test_instance.py ('k') | build/android/pylib/utils/isolator.py » ('j') | no next file with comments »